Don't run query when entering model edit mode & show the correct data source for model (#25565)
* Remove redundant query runs * Don't show dirty mode screen and add exceptional code to handle editing dataset question * Fix unit test * jk no need to do that * Fix e2e tests * Refactor/fix getIsResultDirty selector * Add updateQuestion unit test * update fn name
Showing
- frontend/src/metabase/query_builder/actions/core/updateQuestion.ts 7 additions, 0 deletions...src/metabase/query_builder/actions/core/updateQuestion.ts
- frontend/src/metabase/query_builder/actions/core/updateQuestion.unit.spec.ts 9 additions, 0 deletions...se/query_builder/actions/core/updateQuestion.unit.spec.ts
- frontend/src/metabase/query_builder/actions/ui.js 1 addition, 4 deletionsfrontend/src/metabase/query_builder/actions/ui.js
- frontend/src/metabase/query_builder/components/DatasetEditor/DatasetEditor.jsx 0 additions, 14 deletions.../query_builder/components/DatasetEditor/DatasetEditor.jsx
- frontend/src/metabase/query_builder/components/DatasetEditor/DatasetQueryEditor.jsx 15 additions, 4 deletions...y_builder/components/DatasetEditor/DatasetQueryEditor.jsx
- frontend/src/metabase/query_builder/selectors.js 85 additions, 33 deletionsfrontend/src/metabase/query_builder/selectors.js
- frontend/test/metabase/query_builder/selectors.unit.spec.js 11 additions, 1 deletionfrontend/test/metabase/query_builder/selectors.unit.spec.js
- frontend/test/metabase/scenarios/models/models-metadata.cy.spec.js 0 additions, 4 deletions...test/metabase/scenarios/models/models-metadata.cy.spec.js
- frontend/test/metabase/scenarios/models/models-query-editor.cy.spec.js 5 additions, 5 deletions.../metabase/scenarios/models/models-query-editor.cy.spec.js
- frontend/test/metabase/scenarios/models/reproductions/22517-add-remove-column-drops-metadata.cy.spec.js 0 additions, 3 deletions...uctions/22517-add-remove-column-drops-metadata.cy.spec.js
Loading
Please register or sign in to comment