Skip to content
Snippets Groups Projects
Unverified Commit 7c57bc7c authored by Case Nelson's avatar Case Nelson Committed by GitHub
Browse files

Persist refresh failure email to all admins (#22684)


* Send alert emails on persisted model refresh fail

* Fixing formatting and making sure all the information is available for template

* Fix circular dependency

* Fixing tests and only check advanced perm users if they exist

* Fix merge cruft that was renamed

* Only send emails in persist-refresh

* Add temporary endpoint for testing persist failure emails

* Use `border-box` box sizing in emails

* Use Lato font in emails

* Style model caching error email

* Revert "Add temporary endpoint for testing persist failure emails"

This reverts commit 3d3b8f123060f278374aa5a9301c67d547eb42f7.

* Add is-not-first to error context to help styling

* Only send to admins if advanced-permissions is off

From @noahmoss:
> This is an edge case, but it's possible for an EE instance to downgrade back to OSS. When this happens, users with DB and/or monitoring perms lose these permissions in the app, since it's an EE-only feature. But we don't run any migrations on the permissions table when downgrading happens, so they'll still show up here.
> To fix this you'll need to call metabase.public-settings.premium-features/enable-advanced-permissions? to check whether the instance is EE and advanced perms are enabled before including these users in this query.

* Test private fn

* More robust admin email handling and tests

* Remove commented out code

* Avoid `nth-child` selector for padded sections

* Don't hardcode colors

* Fix line-height

* Use line-height fix for Outlook

* Avoid media-queries and `box-sizing`

* Fix E2E test

Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
parent 4a9be74e
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment