Skip to content

GitLab

Explore

Sign in

Primary navigation

Project

M

Metabase
- Activity
- Members
- Labels
- Issues
- Issue boards
- Milestones
- Iterations
- Wiki
- Requirements
- Environments
- Terraform modules
- Incidents
- Service Desk

Snippets Groups Projects

7cc72cd8

Commit 7cc72cd8 authored 5 years ago by Paul Rosenzweig Committed by Tom Robinson 5 years ago

Downloads
- Patches
- Plain Diff

Don't run native queries with invalid template tags (#10946)

* don't run native queries with invalid template tags

* fix test

parent 4d8a54e1

No related branches found

No related tags found

No related merge requests found

Changes 4

Hide whitespace changes

Inline Side-by-side

Showing

frontend/src/metabase-lib/lib/queries/NativeQuery.js 12 additions, 2 deletions

frontend/src/metabase-lib/lib/queries/NativeQuery.js
frontend/src/metabase/query_builder/components/template_tags/TagEditorParam.jsx 43 additions, 36 deletions

...query_builder/components/template_tags/TagEditorParam.jsx
frontend/test/metabase-lib/lib/queries/NativeQuery.unit.spec.js 26 additions, 0 deletions

...nd/test/metabase-lib/lib/queries/NativeQuery.unit.spec.js
frontend/test/metabase/public/public.e2e.spec.js 4 additions, 0 deletions

frontend/test/metabase/public/public.e2e.spec.js

with 85 additions and 38 deletions

Loading

0% Loading or .

You are about to add 0 people to the discussion. Proceed with caution.

Finish editing this message first!

Please register or sign in to comment