Skip to content
Snippets Groups Projects
Unverified Commit 7dce0f70 authored by Bryan Maass's avatar Bryan Maass Committed by GitHub
Browse files

adds ddiff2 as a dev dependency (#25046)


* adds ddiff2 as a dev dependency

- used in process-query-debug

* Update dev/src/dev/debug_qp.clj

use 0 arg version of println

Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>

Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
parent 40239ad6
No related branches found
No related tags found
No related merge requests found
......@@ -181,7 +181,8 @@
:exclusions [org.clojure/clojure
org.clojure/clojurescript]}
ring/ring-mock {:mvn/version "0.4.0"}
talltale/talltale {:mvn/version "0.5.8"}}
talltale/talltale {:mvn/version "0.5.8"}
lambdaisland/deep-diff2 {:mvn/version "2.3.127"}}
:extra-paths ["dev/src" "local/src" "test" "shared/test" "test_resources"]
:jvm-opts ["-Dmb.run.mode=dev"
......
......@@ -4,6 +4,7 @@
[clojure.pprint :as pprint]
[clojure.string :as str]
[clojure.walk :as walk]
[lambdaisland.deep-diff2 :as ddiff]
[medley.core :as m]
[metabase.mbql.schema :as mbql.s]
[metabase.mbql.util :as mbql.u]
......@@ -171,13 +172,26 @@
(defn- print-diff [before after]
(assert (not= before after))
(let [[only-in-before only-in-after] (data/diff before after)]
(when *print-full?*
(println (u/pprint-to-str 'cyan (format-output after))))
(when (seq only-in-before)
(println (u/colorize 'red (str "-\n" (u/pprint-to-str (format-output only-in-before))))))
(when (seq only-in-after)
(println (u/colorize 'green (str "+\n" (u/pprint-to-str (format-output only-in-after))))))))
(ddiff/pretty-print (ddiff/diff before after)
;; the default printer is very (too?) colorful.
;; this is one that strips color except for the diffs:
(ddiff/printer {:color-scheme
{:lambdaisland.deep-diff2.printer-impl/deletion [:red]
:lambdaisland.deep-diff2.printer-impl/insertion [:green]
:lambdaisland.deep-diff2.printer-impl/other [:white]
:delimiter nil
:tag nil
:nil nil
:boolean nil
:number nil
:string nil
:character nil
:keyword nil
:symbol nil
:function-symbol nil
:class-delimiter nil
:class-name nil}}))
(println))
(defn- debug-query-changes [middleware-var middleware]
(fn [next-middleware]
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment