Require `:encryption` for string settings (#48067)
* Require `:encryption` for string settings For settings that are not typed as JSON, CSV, or strings, encryption now defaults to `:no` (*except* if you have explicitly marked your setting as `:sensitive?` - these will default to `:when-encryption-key-set`). I went through all our settings and provided what I think are reasonable values here. I tried to be conservative - when I wasn't sure whether a stored setting was sensitive, I kept it as encrypted. For example, the `ldap-port` setting is probably non-sensitive but theoretically someone could be using a weird port for security-by-obscurity, so I kept that encrypted. * Change possible values for `:encryption` `:maybe` was confusing: let's be more explicit that the value will be encrypted `:when-encryption-key-set` to make it obvious what actually turns encryption on and off.
Showing
- enterprise/backend/src/metabase_enterprise/advanced_config/models/pulse_channel.clj 1 addition, 0 deletions...abase_enterprise/advanced_config/models/pulse_channel.clj
- enterprise/backend/src/metabase_enterprise/enhancements/integrations/ldap.clj 7 additions, 5 deletions...rc/metabase_enterprise/enhancements/integrations/ldap.clj
- enterprise/backend/src/metabase_enterprise/llm/settings.clj 2 additions, 0 deletionsenterprise/backend/src/metabase_enterprise/llm/settings.clj
- enterprise/backend/src/metabase_enterprise/sso/integrations/sso_settings.clj 82 additions, 63 deletions...src/metabase_enterprise/sso/integrations/sso_settings.clj
- enterprise/backend/test/metabase_enterprise/advanced_config/file/settings_test.clj 2 additions, 1 deletion...etabase_enterprise/advanced_config/file/settings_test.clj
- src/metabase/analytics/snowplow.clj 2 additions, 1 deletionsrc/metabase/analytics/snowplow.clj
- src/metabase/api/embed/common.clj 1 addition, 0 deletionssrc/metabase/api/embed/common.clj
- src/metabase/api/geojson.clj 9 additions, 8 deletionssrc/metabase/api/geojson.clj
- src/metabase/driver.clj 1 addition, 0 deletionssrc/metabase/driver.clj
- src/metabase/email.clj 8 additions, 0 deletionssrc/metabase/email.clj
- src/metabase/embed/settings.clj 2 additions, 1 deletionsrc/metabase/embed/settings.clj
- src/metabase/integrations/common.clj 2 additions, 1 deletionsrc/metabase/integrations/common.clj
- src/metabase/integrations/google.clj 1 addition, 0 deletionssrc/metabase/integrations/google.clj
- src/metabase/integrations/google/interface.clj 2 additions, 1 deletionsrc/metabase/integrations/google/interface.clj
- src/metabase/integrations/ldap.clj 43 additions, 32 deletionssrc/metabase/integrations/ldap.clj
- src/metabase/integrations/slack.clj 4 additions, 0 deletionssrc/metabase/integrations/slack.clj
- src/metabase/metabot/settings.clj 6 additions, 0 deletionssrc/metabase/metabot/settings.clj
- src/metabase/models/cloud_migration.clj 4 additions, 0 deletionssrc/metabase/models/cloud_migration.clj
- src/metabase/models/setting.clj 42 additions, 5 deletionssrc/metabase/models/setting.clj
- src/metabase/models/user.clj 1 addition, 0 deletionssrc/metabase/models/user.clj
Loading
Please register or sign in to comment