Skip to content
Snippets Groups Projects
Unverified Commit 7e3172c3 authored by metabase-bot[bot]'s avatar metabase-bot[bot] Committed by GitHub
Browse files

Fix multi-schema data selector header styling (#40101) (#40159)


* Fix multi-schema data selector header styling

- Makes spacing equal on both sides of the divider
- Changes the divider from the hyphen to the forward slash

* Change the breadcrumb divider in the Table Metadata section

Co-authored-by: default avatarNemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
parent f5370610
No related branches found
No related tags found
No related merge requests found
......@@ -193,7 +193,7 @@ const TableBreadcrumbs = ({ schemaId, onBack }: TableBreadcrumbsProps) => {
<Icon name="chevronleft" size={10} />
{t`Schemas`}
</BackIconContainer>
<span className="mx1">-</span>
<span className="mx1">/</span>
<span>{getSchemaName(schemaId)}</span>
</h4>
);
......
......@@ -27,13 +27,12 @@ export const DataSelectorTablePickerHeaderClickable = styled.span<Props>`
export const DataSelectorTablePickerHeaderDatabaseName = styled.span`
flex-wrap: wrap;
margin-left: ${space(1)};
margin-inline-start: ${space(1)};
`;
export const DataSelectorTablePickerHeaderSchemaName = styled.span`
color: ${color("text-medium")};
flex-wrap: wrap;
margin-left: ${space(1)};
`;
export const LinkToDocsContainer = styled.div`
......@@ -47,3 +46,9 @@ export const NoTablesFound = styled.div`
padding: ${space(4)};
text-align: center;
`;
export const DataSelectorHeaderDivider = styled.span`
color: ${color("text-medium")};
display: inline-block;
margin-inline: ${space(1)};
`;
......@@ -21,6 +21,7 @@ import {
DataSelectorTablePickerHeaderSchemaName as HeaderSchemaName,
LinkToDocsContainer,
NoTablesFound,
DataSelectorHeaderDivider,
} from "./DataSelectorTablePicker.styled";
type DataSelectorTablePickerProps = {
......@@ -170,10 +171,12 @@ const Header = ({
</HeaderClickable>
{selectedSchema?.name && schemas.length > 1 && (
<HeaderSchemaName>
{"- "}
<span data-testid="source-schema">{selectedSchema.displayName()}</span>
</HeaderSchemaName>
<>
<DataSelectorHeaderDivider>/</DataSelectorHeaderDivider>
<HeaderSchemaName data-testid="source-schema">
{selectedSchema.displayName()}
</HeaderSchemaName>
</>
)}
</HeaderContainer>
);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment