Fix saving collection without description. Show warning when All Users has...

Fix saving collection without description. Show warning when All Users has access to a collection another group doesn't

frontend/src/metabase/admin/permissions/selectors.js

@@ -419,6 +419,8 @@ export const getDatabasesPermissionsGrid = createSelector(
 );
 
 const getCollections = (state) => state.permissions.collections;
+const getCollectionPermission = (permissions, groupId, { collectionId }) =>
+    getIn(permissions, [groupId, collectionId])
 
 export const getCollectionsPermissionsGrid = createSelector(
     getCollections, getGroups, getPermissions,
@@ -427,6 +429,8 @@ export const getCollectionsPermissionsGrid = createSelector(
             return null;
         }
 
+        const defaultGroup = _.find(groups, isDefaultGroup);
+
         return {
             type: "collection",
             groups,
@@ -435,16 +439,19 @@ export const getCollectionsPermissionsGrid = createSelector(
                     options(groupId, entityId) {
                         return [OPTION_COLLECTION_WRITE, OPTION_COLLECTION_READ, OPTION_NONE];
                     },
-                    getter(groupId, { collectionId }) {
-                        return getIn(permissions, [groupId, collectionId]);
+                    getter(groupId, entityId) {
+                        return getCollectionPermission(permissions, groupId, entityId);
                     },
                     updater(groupId, { collectionId }, value) {
                         return assocIn(permissions, [groupId, collectionId], value);
                     },
                     confirm(groupId, entityId, value) {
-                        return [];
+                        return [
+                            getPermissionWarningModal(getCollectionPermission, null, defaultGroup, permissions, groupId, entityId, value)
+                        ];
                     },
                     warning(groupId, entityId) {
+                        return getPermissionWarning(getCollectionPermission, null, defaultGroup, permissions, groupId, entityId);
                     }
                 },
             },

frontend/src/metabase/questions/collections.js

@@ -21,6 +21,10 @@ export const loadCollections = createAction(LOAD_COLLECTIONS, CollectionsApi.lis
 export const saveCollection = createThunkAction(SAVE_COLLECTION, (collection) => {
     return async (dispatch, getState) => {
         try {
+            if (!collection.description) {
+                // description must be nil or non empty string
+                collection = { ...collection, description: null }
+            }
             let response;
             if (collection.id == null) {
                 MetabaseAnalytics.trackEvent("Collections", "Create");