Fix no visual feedback when updating data model field details (#20915)

* Revert field update to only notify without allow undoing

* Add feedback when updating field details on datamodel

frontend/src/metabase/admin/datamodel/components/database/MetadataTable.jsx

@@ -53,7 +53,7 @@ export default class MetadataTable extends Component {
 
   updateProperty(name, value) {
     this.setState({ saving: true });
-    this.props.table.update({ [name]: value });
+    this.props.table.updateProperty(name, value);
   }
 
   onNameChange(event) {

frontend/src/metabase/admin/datamodel/containers/FieldApp.jsx

@@ -69,7 +69,7 @@ const mapDispatchToProps = {
   fetchDatabaseMetadata: Databases.actions.fetchDatabaseMetadata,
   fetchTableMetadata: Tables.actions.fetchMetadataAndForeignTables,
   fetchFieldValues: Fields.actions.fetchFieldValues,
-  updateField: Fields.actions.update,
+  updateField: Fields.actions.updateField,
   updateFieldValues: Fields.actions.updateFieldValues,
   updateFieldDimension: Fields.actions.updateFieldDimension,
   deleteFieldDimension: Fields.actions.deleteFieldDimension,

frontend/src/metabase/entities/fields.js

 import { t } from "ttag";
-import { createEntity, undo } from "metabase/lib/entities";
+import { createEntity, notify } from "metabase/lib/entities";
 import {
   compose,
   withAction,
@@ -91,7 +91,7 @@ const Fields = createEntity({
       return Fields.actions.update(
         { id: field.id },
         field,
-        undo(opts, field.display_name, t`updated`),
+        notify(opts, field.display_name, t`updated`),
       );
     },
     // Docstring from m.api.field:

frontend/src/metabase/entities/tables.js

-import { createEntity } from "metabase/lib/entities";
+import { t } from "ttag";
+import { createEntity, notify } from "metabase/lib/entities";
 import {
   createThunkAction,
   compose,
@@ -73,6 +74,13 @@ const Tables = createEntity({
 
   // ACTION CREATORS
   objectActions: {
+    updateProperty(entityObject, name, value, opts) {
+      return Tables.actions.update(
+        entityObject,
+        { [name]: value },
+        notify(opts, `Table ${name}`, t`updated`),
+      );
+    },
     // loads `query_metadata` for a single table
     fetchMetadata: compose(
       withAction(FETCH_METADATA),

frontend/src/metabase/lib/entities.js

@@ -259,14 +259,12 @@ export function createEntity(def) {
         );
 
         if (notify) {
-          // pick only the attributes that were updated
-          const undoObject = _.pick(
-            originalObject,
-            ...Object.keys(updatedObject || {}),
-          );
-          // https://github.com/metabase/metabase/pull/20874#pullrequestreview-902384264
-          const canUndo = !hasCircularReference(undoObject);
-          if (notify.undo && canUndo) {
+          if (notify.undo) {
+            // pick only the attributes that were updated
+            const undoObject = _.pick(
+              originalObject,
+              ...Object.keys(updatedObject || {}),
+            );
             dispatch(
               addUndo({
                 actions: [
@@ -613,16 +611,6 @@ export function createEntity(def) {
   return entity;
 }
 
-function hasCircularReference(object) {
-  try {
-    JSON.stringify(object);
-  } catch (error) {
-    return true;
-  }
-
-  return false;
-}
-
 export function combineEntities(entities) {
   const entitiesMap = {};
   const reducersMap = {};