Fix table name gets included in pinned dimension names even for the query root table (#18753)

frontend/src/metabase-lib/lib/Dimension.js

@@ -598,6 +598,10 @@ export class FieldDimension extends Dimension {
     });
   }
 
+  tableId() {
+    return this.field()?.table?.id;
+  }
+
   /**
    * Return a copy of this FieldDimension that excludes `options`.
    */
@@ -1225,10 +1229,6 @@ export class TemplateTagDimension extends FieldDimension {
     return dimension ? dimension.field() : super.field();
   }
 
-  tableId() {
-    return this.field()?.table?.id;
-  }
-
   name() {
     return this.field().name;
   }

frontend/test/metabase/scenarios/question/summarization.cy.spec.js

@@ -45,6 +45,7 @@ describe("scenarios > question > summarize sidebar", () => {
 
     // Displayed in the pinned list
     cy.findByTestId("pinned-dimensions").within(() => {
+      cy.findByText("Orders → Total").should("not.exist");
       getDimensionByName({ name: "Total" }).should(
         "have.attr",
         "aria-selected",
@@ -60,6 +61,27 @@ describe("scenarios > question > summarize sidebar", () => {
     });
   });
 
+  it("selected dimensions from another table includes the table name when becomes pinned to the top", () => {
+    getDimensionByName({ name: "State" }).click();
+
+    cy.button("Done").click();
+    cy.findAllByText("Summarize")
+      .first()
+      .click();
+
+    cy.findByTestId("pinned-dimensions").within(() => {
+      getDimensionByName({ name: "People → State" }).should(
+        "have.attr",
+        "aria-selected",
+        "true",
+      );
+    });
+
+    getRemoveDimensionButton({ name: "People → State" }).click();
+
+    cy.findByText("People → State").should("not.exist");
+  });
+
   it("selecting a binning adds a dimension", () => {
     getDimensionByName({ name: "Total" }).click();