Merge pull request #497 from metabase/fix_card_favorite_button_state

correctly color card favorite button on query builder.

resources/frontend_client/app/query_builder/card_favorite_button.react.js

@@ -74,10 +74,15 @@ export default React.createClass({
     },
 
     render: function() {
-        var fillColor = (this.state.favorite) ? 'text-gold' : 'text-grey-1';
+        var iconClasses = cx({
+            'mx1': true,
+            'transition-color': true,
+            'text-grey-3': !this.state.favorite,
+            'text-gold': this.state.favorite
+        });
 
         return (
-            <a className="mx1 text-grey-4 text-gold-hover transition-color" href="#" onClick={this.toggleFavorite}>
+            <a className={iconClasses} href="#" onClick={this.toggleFavorite}>
                 <Icon name="star" width="18px" height="18px"></Icon>
             </a>
         );