fix field filter missing schema metadata (#19536)

frontend/src/metabase/query_builder/components/template_tags/TagEditorParam.jsx

@@ -5,6 +5,7 @@ import _ from "underscore";
 import { connect } from "react-redux";
 import { Link } from "react-router";
 
+import Schemas from "metabase/entities/schemas";
 import Toggle from "metabase/components/Toggle";
 import InputBlurChange from "metabase/components/InputBlurChange";
 import Select, { Option } from "metabase/components/Select";
@@ -163,19 +164,23 @@ export default class TagEditorParam extends Component {
 
             {(!hasSelectedDimensionField ||
               (hasSelectedDimensionField && fieldMetadataLoaded)) && (
-              <SchemaTableAndFieldDataSelector
-                databases={databases}
-                selectedDatabaseId={database ? database.id : null}
-                selectedTableId={table ? table.id : null}
-                selectedFieldId={
-                  hasSelectedDimensionField ? tag.dimension[1] : null
-                }
-                setFieldFn={fieldId => this.setDimension(fieldId)}
-                className="AdminSelect flex align-center"
-                isInitiallyOpen={!tag.dimension}
-                triggerIconSize={12}
-                renderAsSelect={true}
-              />
+              <Schemas.Loader id={table?.schema?.id}>
+                {() => (
+                  <SchemaTableAndFieldDataSelector
+                    databases={databases}
+                    selectedDatabaseId={database ? database.id : null}
+                    selectedTableId={table ? table.id : null}
+                    selectedFieldId={
+                      hasSelectedDimensionField ? tag.dimension[1] : null
+                    }
+                    setFieldFn={fieldId => this.setDimension(fieldId)}
+                    className="AdminSelect flex align-center"
+                    isInitiallyOpen={!tag.dimension}
+                    triggerIconSize={12}
+                    renderAsSelect={true}
+                  />
+                )}
+              </Schemas.Loader>
             )}
           </div>
         )}

frontend/test/metabase/scenarios/native/reproductions/19451.cy.spec.js

+import { restore } from "__support__/e2e/cypress";
+import { SAMPLE_DATASET } from "__support__/e2e/cypress_sample_dataset";
+
+const { PRODUCTS } = SAMPLE_DATASET;
+
+const question = {
+  name: "19451",
+  native: {
+    query: "select count(*) from products where {{filter}}",
+    "template-tags": {
+      filter: {
+        id: "1b33304a-18ea-cc77-083a-b5225954f200",
+        name: "filter",
+        "display-name": "Filter",
+        type: "dimension",
+        dimension: ["field", PRODUCTS.ID, null],
+        "widget-type": "id",
+        default: null,
+      },
+    },
+  },
+  display: "scalar",
+};
+
+describe("issue 19451", () => {
+  beforeEach(() => {
+    restore();
+    cy.signInAsAdmin();
+
+    cy.createNativeQuestion(question).then(({ body: { id } }) => {
+      cy.intercept("POST", `/api/card/${id}/query`).as("cardQuery");
+
+      cy.visit(`/question/${id}`);
+      cy.wait("@cardQuery");
+    });
+  });
+
+  it("question field filter shows all tables from a selected database (metabase#19451)", () => {
+    cy.findByText("Open Editor").click();
+    cy.icon("variable").click();
+    cy.findByText("Products").click();
+    cy.icon("chevronleft").click();
+
+    cy.findByText("Products");
+    cy.findByText("Orders");
+    cy.findByText("People");
+    cy.findByText("Reviews");
+  });
+});