Fix e2e util `cypressWaitAll` (#40572) (#40611)

* Fix e2e utils

* Update e2e/support/commands/api/composite/createDashboardWithQuestions.js



* Remove unnecessary return



---------

Co-authored-by: Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>

e2e/support/commands/api/composite/createDashboardWithQuestions.js

@@ -10,7 +10,10 @@ Cypress.Commands.add(
           questions.map(query =>
             cy.createQuestionAndAddToDashboard(query, dashboard.id),
           ),
-        ).then(questions => {
+        ).then(dashcardResponses => {
+          const questions = dashcardResponses.map(
+            dashcardResponse => dashcardResponse.body.card,
+          );
           return {
             questions,
             dashboard,

e2e/support/commands/api/composite/createQuestionAndAddToDashboard.js

@@ -26,7 +26,7 @@ Cypress.Commands.add(
             })
             .then(response => ({
               ...response,
-              body: response.body.dashcards[0],
+              body: response.body.dashcards.at(-1),
             })),
         ),
     ),

e2e/support/helpers/e2e-misc-helpers.js

@@ -101,28 +101,29 @@ export function interceptPromise(method, path) {
  *   cy.visit(`/dashboard/1`);
  * });
  */
-const cypressWaitAllRecursive = (results, currentCommand, commands) => {
-  return currentCommand.then(result => {
-    results.push(result);
+const cypressWaitAllRecursive = (results, commands) => {
+  const [nextCommand, ...restCommands] = commands;
+  if (!nextCommand) {
+    return;
+  }
 
-    const [nextCommand, ...rest] = Array.from(commands);
+  return nextCommand.then(result => {
+    results.push(result);
 
     if (nextCommand == null) {
-      return results;
+      return;
     }
 
-    return cypressWaitAllRecursive(results, nextCommand, rest);
+    return cypressWaitAllRecursive(results, restCommands);
   });
 };
 
 export const cypressWaitAll = function (commands) {
   const results = [];
 
-  return cypressWaitAllRecursive(
-    results,
-    cy.wrap(null, { log: false }),
-    commands,
-  );
+  return cy.wrap(results).then(() => {
+    cypressWaitAllRecursive(results, commands);
+  });
 };
 
 /**