Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
8671f6db
Unverified
Commit
8671f6db
authored
3 years ago
by
Nemanja Glumac
Committed by
GitHub
3 years ago
Browse files
Options
Downloads
Patches
Plain Diff
#16789 Repro: Clicking column name when dropdown menu is open should close menu (#16807)
* Simplify the existing test * Add repro for #16789
parent
f5fc2bae
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
frontend/test/metabase/scenarios/visualizations/table.cy.spec.js
+23
-16
23 additions, 16 deletions
...d/test/metabase/scenarios/visualizations/table.cy.spec.js
with
23 additions
and
16 deletions
frontend/test/metabase/scenarios/visualizations/table.cy.spec.js
+
23
−
16
View file @
8671f6db
import
{
restore
,
visitQuestionAdhoc
,
popover
}
from
"
__support__/e2e/cypress
"
;
import
{
SAMPLE_DATASET
}
from
"
__support__/e2e/cypress_sample_dataset
"
;
const
{
PEOPLE_ID
}
=
SAMPLE_DATASET
;
const
testQuery
=
{
database
:
1
,
query
:
{
"
source-table
"
:
PEOPLE_ID
,
},
type
:
"
query
"
,
};
import
{
restore
,
openPeopleTable
,
popover
}
from
"
__support__/e2e/cypress
"
;
describe
(
"
scenarios > visualizations > table
"
,
()
=>
{
beforeEach
(()
=>
{
...
...
@@ -19,10 +8,7 @@ describe("scenarios > visualizations > table", () => {
});
it
(
"
should allow to display any column as link with extrapolated url and text
"
,
()
=>
{
visitQuestionAdhoc
({
dataset_query
:
testQuery
,
display
:
"
table
"
,
});
openPeopleTable
();
cy
.
wait
(
"
@dataset
"
);
cy
.
findByText
(
"
City
"
).
click
();
...
...
@@ -57,4 +43,25 @@ describe("scenarios > visualizations > table", () => {
"
http://metabase.com/people/1
"
,
);
});
it
.
skip
(
"
should close the colum popover on subsequent click (metabase#16789)
"
,
()
=>
{
openPeopleTable
();
cy
.
wait
(
"
@dataset
"
);
cy
.
findByText
(
"
City
"
).
click
();
popover
().
within
(()
=>
{
cy
.
icon
(
"
arrow_up
"
);
cy
.
icon
(
"
arrow_down
"
);
cy
.
icon
(
"
gear
"
);
cy
.
findByText
(
"
Filter by this column
"
);
cy
.
findByText
(
"
Distribution
"
);
cy
.
findByText
(
"
Distincts
"
);
});
cy
.
findByText
(
"
City
"
).
click
();
// Although arbitrary waiting is considered an anti-pattern and a really bad practice, I couldn't find any other way to reproduce this issue.
// Cypress is too fast and is doing the assertions in that split second while popover is reloading which results in a false positive result.
cy
.
wait
(
100
);
popover
().
should
(
"
not.exist
"
);
});
});
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment