Skip to content
Snippets Groups Projects
Unverified Commit 86b4a3e6 authored by john-metabase's avatar john-metabase Committed by GitHub
Browse files

Sets imported serialized DB initial_sync_status=complete (#30143)

Resolves #29687
parent 50dd7c02
Branches
Tags
No related merge requests found
......@@ -336,8 +336,8 @@
clean-entity)))))
(testing "for Databases"
(doseq [{:keys [name] :as coll} (get @entities "Database")]
(is (= (clean-entity coll)
(doseq [{:keys [name] :as db} (get @entities "Database")]
(is (= (assoc (clean-entity db) :initial_sync_status "complete")
(->> (t2/select-one 'Database :name name)
(serdes/extract-one "Database" {})
clean-entity)))))
......
......@@ -163,6 +163,7 @@
(reset! db2d (t2/select-one Database :name (:name @db2s)))
(is (= 3 (t2/count Database)))
(is (every? #(= "complete" (:initial_sync_status %)) (t2/select Database)))
(is (= #{"db1" "db2" "test-data"}
(t2/select-fn-set :name Database)))
(is (= #{(:id @db1d) (:id @db2d)}
......
......@@ -205,11 +205,12 @@
:existing-engine existing-engine
:new-engine new-engine})))))))
(defn- pre-insert [{:keys [details], :as database}]
(-> (cond-> database
(not details) (assoc :details {}))
handle-secrets-changes
(assoc :initial_sync_status "incomplete")))
(defn- pre-insert [{:keys [details initial_sync_status], :as database}]
(-> database
(cond->
(not details) (assoc :details {})
(not initial_sync_status) (assoc :initial_sync_status "incomplete"))
handle-secrets-changes))
(defmethod mi/perms-objects-set Database
[{db-id :id} read-or-write]
......@@ -323,7 +324,8 @@
[database]
(-> database
serdes/load-xform-basics
(update :creator_id serdes/*import-user*)))
(update :creator_id serdes/*import-user*)
(assoc :initial_sync_status "complete")))
(defmethod serdes/load-insert! "Database" [_ ingested]
(let [m (get-method serdes/load-insert! :default)]
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment