Skip to content
Snippets Groups Projects
Commit 873a05d5 authored by Allen Gilliland's avatar Allen Gilliland
Browse files

Merge pull request #416 from metabase/remove_old_query_dependency

remove a stale old bit of code in the frontend that was still referen…
parents 77746e5f 037fe66d
No related branches found
No related tags found
No related merge requests found
......@@ -9,7 +9,7 @@
var CardDirectives = angular.module('corvus.card.directives', []);
CardDirectives.directive('cvCard', ['Card', 'Metabase', 'CorvusAlert', 'Query', 'QueryResult', 'VisualizationSettings', '$timeout', function(Card, Metabase, CorvusAlert, Query, QueryResult, VisualizationSettings, $timeout) {
CardDirectives.directive('cvCard', ['Card', 'Metabase', 'CorvusAlert', 'VisualizationSettings', '$timeout', function(Card, Metabase, CorvusAlert, VisualizationSettings, $timeout) {
var DATA_TIMEOUT_DELAY_IN_MS = 1000;
......@@ -261,24 +261,8 @@ CardDirectives.directive('cvCard', ['Card', 'Metabase', 'CorvusAlert', 'Query',
} else {
scope.cardDataEmpty = true;
//if card is backed by SQL query, find out why there is no data
if (scope.card.dataset_query.type == 'result') {
Query.results({
'queryId': scope.card.dataset_query.result.query_id
}, function(results) {
if (results[0]) {
QueryResult.response({
'resultId': results[0].id
}, function(queryResponse) {
if (queryResponse) {
scope.sqlError = queryResponse.sql_error;
}
});
}
});
//if card is backed by structured query, check to see if the table is empty
} else if (scope.card.dataset_query.type == 'query') {
// if card is backed by structured query, check to see if the table is empty
if (scope.card.dataset_query.type == 'query') {
Metabase.table_get({
'tableId': scope.card.dataset_query.query.source_table
}, function(source_table) {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment