Skip to content
Snippets Groups Projects
Unverified Commit 8889384e authored by Ryan Laurie's avatar Ryan Laurie Committed by GitHub
Browse files

update modal header (#24001)

parent f6babce7
Branches
Tags
No related merge requests found
......@@ -26,6 +26,8 @@ export const ModalHeader = styled.div`
`;
export const ModalBody = styled.div`
border-top: 1px solid ${color("border")};
margin-top: 1.5rem;
overflow-y: auto;
flex: 1;
`;
......
......@@ -110,7 +110,7 @@ const BulkFilterModal = ({
return (
<ModalRoot>
<ModalHeader>
<ModalTitle>{t`Filter by`}</ModalTitle>
<ModalTitle>{getTitle(query, sections.length === 1)}</ModalTitle>
{showSearch ? (
<FieldSearch value={searchQuery} onChange={setSearchQuery} />
) : (
......@@ -256,15 +256,13 @@ const getQuery = (question: Question) => {
}
};
const getTitle = (question: Question, query: StructuredQuery) => {
const getTitle = (query: StructuredQuery, singleTable: boolean) => {
const table = query.table();
if (question.isSaved()) {
return t`Filter ${question.displayName()}`;
} else if (table) {
return t`Filter ${table.displayName()}`;
if (singleTable) {
return t`Filter by ${table.displayName()}`;
} else {
return t`Filter`;
return t`Filter by`;
}
};
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment