Cleanup QuestionDataSource and fix breadcrumb links issues (#18962)
* Remove not used `noLink` prop * Namespace URL generators * Fix HeaderBreadcrumbs font-size in "head" mode * Add unit-tests for QuestionDataSource * Allow using react nodes in breadcrumbs * Use func declaration for QuestionDataSource * Add prop-types * Simplify query assignment expr * Don't swallow errors in QuestionDataSource tests * Add repro for #17961 (unit) * Allow passing custom divider for HeaderBreadcrumbs * Fix join tables breadcrumb links * Add extra saved question utils * Add tests for nested questions * Fix source question link * Don't show source question's schema * Fix breadcrumb colors * Fix tests * Fix breadcrumb colors * Use saved-questions lib utils for DataSelector
Showing
- frontend/src/metabase/lib/saved-questions/saved-questions.js 12 additions, 0 deletionsfrontend/src/metabase/lib/saved-questions/saved-questions.js
- frontend/src/metabase/lib/saved-questions/saved-questions.unit.spec.js 53 additions, 0 deletions...metabase/lib/saved-questions/saved-questions.unit.spec.js
- frontend/src/metabase/query_builder/components/DataSelector.jsx 6 additions, 4 deletions...nd/src/metabase/query_builder/components/DataSelector.jsx
- frontend/src/metabase/query_builder/components/data-search/utils.js 2 additions, 8 deletions...rc/metabase/query_builder/components/data-search/utils.js
- frontend/src/metabase/query_builder/components/view/HeaderBreadcrumbs/HeaderBreadcrumbs.jsx 37 additions, 9 deletions...r/components/view/HeaderBreadcrumbs/HeaderBreadcrumbs.jsx
- frontend/src/metabase/query_builder/components/view/HeaderBreadcrumbs/HeaderBreadcrumbs.styled.jsx 21 additions, 14 deletions...nents/view/HeaderBreadcrumbs/HeaderBreadcrumbs.styled.jsx
- frontend/src/metabase/query_builder/components/view/QuestionDataSource.jsx 88 additions, 38 deletions...base/query_builder/components/view/QuestionDataSource.jsx
- frontend/src/metabase/query_builder/components/view/QuestionDataSource.styled.jsx 10 additions, 0 deletions...ery_builder/components/view/QuestionDataSource.styled.jsx
- frontend/src/metabase/query_builder/components/view/QuestionDataSource.unit.spec.js 515 additions, 0 deletions...y_builder/components/view/QuestionDataSource.unit.spec.js
- frontend/test/metabase/scenarios/native/native.cy.spec.js 7 additions, 4 deletionsfrontend/test/metabase/scenarios/native/native.cy.spec.js
- frontend/test/metabase/scenarios/question/notebook.cy.spec.js 20 additions, 4 deletions...tend/test/metabase/scenarios/question/notebook.cy.spec.js
Loading
Please register or sign in to comment