Use display name from model for implicit actions (#30356)
* Use display name from card for implicit actions * Remove fields arg from generateFieldSettingsFromParameters * Update implicit action test to include display-name * Tidy * Fix unit tests * Fix e2e test * Only include display-name in the parameters for implicit action types * Use `field.displayName()` * Fix some tests * Attempt to fix test * Fix ActionParametersInputForm unit tests * Only generate field settings from parameters if action.type is implicit * Fix e2e tests * Fix unit tests * Fix tests
Showing
- e2e/test/scenarios/dashboard/actions-on-dashboards.cy.spec.js 16 additions, 16 deletions...test/scenarios/dashboard/actions-on-dashboards.cy.spec.js
- e2e/test/scenarios/models/model-actions.cy.spec.js 2 additions, 2 deletionse2e/test/scenarios/models/model-actions.cy.spec.js
- frontend/src/metabase-types/api/mocks/actions.ts 1 addition, 0 deletionsfrontend/src/metabase-types/api/mocks/actions.ts
- frontend/src/metabase/actions/components/ActionViz/Action.unit.spec.tsx 16 additions, 2 deletions...etabase/actions/components/ActionViz/Action.unit.spec.tsx
- frontend/src/metabase/actions/containers/ActionParametersInputForm/ActionParametersInputForm.unit.spec.tsx 33 additions, 5 deletions...rametersInputForm/ActionParametersInputForm.unit.spec.tsx
- frontend/src/metabase/actions/hooks/use-action-form/utils.ts 14 additions, 27 deletionsfrontend/src/metabase/actions/hooks/use-action-form/utils.ts
- frontend/src/metabase/actions/hooks/use-action-form/utils.unit.spec.ts 32 additions, 161 deletions...metabase/actions/hooks/use-action-form/utils.unit.spec.ts
- frontend/src/metabase/public/containers/PublicAction/PublicAction.unit.spec.tsx 2 additions, 0 deletions...public/containers/PublicAction/PublicAction.unit.spec.tsx
- src/metabase/models/action.clj 7 additions, 3 deletionssrc/metabase/models/action.clj
- test/metabase/models/action_test.clj 15 additions, 9 deletionstest/metabase/models/action_test.clj
Loading
Please register or sign in to comment