Skip to content
Snippets Groups Projects
Unverified Commit 8b341b1a authored by Anton Kulyk's avatar Anton Kulyk Committed by GitHub
Browse files

Add global navigation sidebar (#21069)


* Prototype new nav skeleton (#20875)

* yarn

* begin basic layout flip

* rough in collections list

* position query builder

* remove fitViewport from QB to fix layout quirks

* extract search

* clean up props

* position search / style

* fix dashboard layout

* fix search icon

* move ProfileLink

* tweak spacing

* fix burger

* add basic toggle

* tweak layout for sidebar toggle

* tweak style

* tweak sidebar sizing

* Quick fix to prototype starting points init (#20922)

* fix scroll overflow on sidebar

Co-authored-by: default avatarGustavo Saiani <gustavo@poe.ma>

* add currentUser to profile link

* move footer items out of collection sidebar

* tweak footer style

* fix hover style

* clean up footer

* fixup

* remove un-needed overflow hidden

* hide app bar when in admin mode

* merge sidebar header into new color scheme / nav layout

* clean up headers

* fix root collection spacing

* smaller font size for nav items

* provide flex context, fixes metadata editing

* fix login page

* Remove console logs

* Put user's personal collection under Our analytics (#21061)

* Browsing | Handle long item names in the sidebar (#21063)

* Handle long names in the nav sidebar

* Show tooltip with a full item name if its cut

* Browsing | Fix data reference & admin permissions layout (#21101)

* Remove admin navbar CSS fix

* Handle admin navbar in root App component

* Extract styled components

* Fix data reference layout

* Fix main container height

* Browsing | Hide sidebar for questions, models and dashboards on page open (#21064)

* Manage default sidebar visibility

* Handle ad-hoc questions better

* Move nav elements based on feedback (#21190)

* scoot buttons around

* move logo to appbar, scoot search

* remove user footer, home link [ci skip]

* review feedback [ci skip]

* fix accidental removal of links (minimalism was a fad anyway) (#21192)

* add button classes to new button (#21213)

* Nav visual changes (#21223)

* switch nav bg + move styling to NavRoot

* readable text

* increase contrast

* selected icon color

* remove bottom padding

* search bar color

* restructure sidebar position

* fix sidebar header color

* move to fixed when small

* fix multiple scrollbars

* fix sidebar width

* home as own item, gear below

* fix admin nav

* extract nav constant, fix types

* remove unused constant [ci skip]

* New nav - get base colors in order (#21262)

* new sidebar button

* nav bg to bg-light

* fix link track, remove extra home link

* color tweaks

* swap colors

* Fix E2E tests for new navigation UI (#21196)

* Use `main` HTML tag for main page content

* Add extra UI helpers for Cypress

* Fix tests failing due to nav UI changes

* Remove not needed NavBar code

* Fix loading databases list

* Use `navigationSidebar` helper for collections

* Use `navigationSidebar` for collection tests

* Close sidebar in SQL filters tests

* Extract AppBar component to `metabase/nav`

* Fix test

* Fix test

* Skip sidebar visibility control test

* Fix JSON engine DB check

* Fix DatasetEditor edit bar colors

* Fix global containers heights

* Fix tests scrolling target

* Fix styles

* Fix navbar cypress helpers

* [ci nocache]

* Fix scroll in e2e test

* Browsing | Manage sidebar state with redux (#21226)

* Move navbar state to redux

* Hide sidbebar using CSS

* Fix native E2E test

* Fix native e2e test

* Fix model tests

* Use more accurate element getters

* Fix e2e tests

* Browsing | Fix dashboard UI (#21233)

* Fix parameter widgets event listeners

* Attach scroll events to "main" instead of window

* Resize filters panel when navigation sidebar open

* Reorder imports at App

* Hide AppBar and NavBar when editing dashboard

* Fix navbar & appbar visibility

* Fix filter positions

* Extract `getMainElement` helper

* Update unit tests

* Fix test

* Browse fix bulk actions (#21320)

* make bulk action bar aware of sidebar, remove extraneous layout components

* clean up styling

* convert BulkActionBar to tsx

* Fix types

Co-authored-by: default avatarKyle Doherty <5248953+kdoh@users.noreply.github.com>
Co-authored-by: default avatarGustavo Saiani <gustavo@poe.ma>
Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@gmail.com>
parent c6aff0bf
Branches
Tags
No related merge requests found
Showing
with 265 additions and 114 deletions
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment