Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
8b401d03
Unverified
Commit
8b401d03
authored
7 years ago
by
Tom Robinson
Browse files
Options
Downloads
Patches
Plain Diff
Fix flow error and better comment
parent
fd17c05a
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
frontend/src/metabase/hoc/Routeless.jsx
+3
-1
3 additions, 1 deletion
frontend/src/metabase/hoc/Routeless.jsx
with
3 additions
and
1 deletion
frontend/src/metabase/hoc/Routeless.jsx
+
3
−
1
View file @
8b401d03
...
...
@@ -24,6 +24,7 @@ export default (ComposedComponent) => class extends Component {
static
displayName
=
"
Routeless[
"
+
(
ComposedComponent
.
displayName
||
ComposedComponent
.
name
)
+
"
]
"
;
_state
:
any
;
_timeout
:
any
;
componentWillMount
()
{
const
push
=
this
.
props
.
_routeless_push
;
...
...
@@ -41,7 +42,8 @@ export default (ComposedComponent) => class extends Component {
// if the state previously was the saved one and is now not, then we probably
// hit the back button, so close the wrapped component
if
(
location
.
state
===
this
.
_state
&&
nextLocation
.
state
!==
this
.
_state
)
{
// close in a timeout in case it will be closed anyway and the URL changes.
// perform this in a timeout because the component may be unmounted anyway, in which
// case calling onClose again may cause problems.
// alternatively may be able to tighten up the logic above
this
.
_timeout
=
setTimeout
(()
=>
{
this
.
props
.
onClose
();
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment