Test fixes

test/metabase/api/setup_test.clj

@@ -5,7 +5,9 @@
              [http-client :as http]
              [public-settings :as public-settings]
              [setup :as setup]]
-            [metabase.test.util :as tu]))
+            [metabase.models.user :refer [User]]
+            [metabase.test.util :as tu]
+            [toucan.db :as db]))
 
 ;; ## POST /api/setup/user
 ;; Check that we can create a new superuser via setup-token
@@ -13,17 +15,20 @@
   (expect
     [true
      email]
-    (tu/with-temporary-setting-values [admin-email nil]
-      [(tu/is-uuid-string? (:id (http/client :post 200 "setup" {:token (setup/create-token!)
-                                                                :prefs {:site_name "Metabase Test"}
-                                                                :user  {:first_name (tu/random-name)
-                                                                        :last_name  (tu/random-name)
-                                                                        :email      email
-                                                                        :password   "anythingUP12!!"}})))
-       (do
-         ;; reset our setup token
-         (setup/create-token!)
-         (public-settings/admin-email))])))
+    (try
+      (tu/with-temporary-setting-values [admin-email nil]
+        [(tu/is-uuid-string? (:id (http/client :post 200 "setup" {:token (setup/create-token!)
+                                                                  :prefs {:site_name "Metabase Test"}
+                                                                  :user  {:first_name (tu/random-name)
+                                                                          :last_name  (tu/random-name)
+                                                                          :email      email
+                                                                          :password   "anythingUP12!!"}})))
+         (do
+           ;; reset our setup token
+           (setup/create-token!)
+           (public-settings/admin-email))])
+      (finally
+        (db/delete! User :email email)))))
 
 
 ;; Test input validations