fix static viz waterfall colors (#24852)
* fix static viz waterfall colors
* tests
* Pass colors into StaticChart as third argument
This might not be the best design, so changes are welcome, but I added this to properly consider the case where the
application-colors are different, but the chart has no viz-settings: application-colors were being ignored (as they
were passed into options, but not pulled out of options into the colors arg).
* review
Co-authored-by:
Adam James <adam.vermeer2@gmail.com>
Showing
- frontend/src/metabase/static-viz/components/CategoricalAreaChart/CategoricalAreaChart.jsx 6 additions, 4 deletions.../components/CategoricalAreaChart/CategoricalAreaChart.jsx
- frontend/src/metabase/static-viz/components/CategoricalBarChart/CategoricalBarChart.jsx 6 additions, 4 deletions...iz/components/CategoricalBarChart/CategoricalBarChart.jsx
- frontend/src/metabase/static-viz/components/CategoricalLineChart/CategoricalLineChart.jsx 6 additions, 4 deletions.../components/CategoricalLineChart/CategoricalLineChart.jsx
- frontend/src/metabase/static-viz/components/CategoricalWaterfallChart/CategoricalWaterfallChart.jsx 14 additions, 17 deletions...s/CategoricalWaterfallChart/CategoricalWaterfallChart.jsx
- frontend/src/metabase/static-viz/components/TimeSeriesAreaChart/TimeSeriesAreaChart.jsx 6 additions, 4 deletions...iz/components/TimeSeriesAreaChart/TimeSeriesAreaChart.jsx
- frontend/src/metabase/static-viz/components/TimeSeriesBarChart/TimeSeriesBarChart.jsx 6 additions, 4 deletions...-viz/components/TimeSeriesBarChart/TimeSeriesBarChart.jsx
- frontend/src/metabase/static-viz/components/TimeSeriesLineChart/TimeSeriesLineChart.jsx 6 additions, 4 deletions...iz/components/TimeSeriesLineChart/TimeSeriesLineChart.jsx
- frontend/src/metabase/static-viz/components/TimeSeriesWaterfallChart/TimeSeriesWaterfallChart.jsx 13 additions, 17 deletions...nts/TimeSeriesWaterfallChart/TimeSeriesWaterfallChart.jsx
- frontend/src/metabase/static-viz/containers/StaticChart/StaticChart.tsx 16 additions, 12 deletions...etabase/static-viz/containers/StaticChart/StaticChart.tsx
- frontend/src/metabase/static-viz/containers/StaticChart/types.ts 2 additions, 0 deletions...d/src/metabase/static-viz/containers/StaticChart/types.ts
- frontend/src/metabase/static-viz/lib/axes.js 6 additions, 6 deletionsfrontend/src/metabase/static-viz/lib/axes.js
- frontend/src/metabase/static-viz/lib/colors.ts 29 additions, 0 deletionsfrontend/src/metabase/static-viz/lib/colors.ts
- resources/frontend_shared/static_viz_interface.js 4 additions, 2 deletionsresources/frontend_shared/static_viz_interface.js
- src/metabase/pulse/render/body.clj 3 additions, 3 deletionssrc/metabase/pulse/render/body.clj
- src/metabase/pulse/render/js_svg.clj 5 additions, 2 deletionssrc/metabase/pulse/render/js_svg.clj
- test/metabase/pulse/render/js_svg_test.clj 3 additions, 2 deletionstest/metabase/pulse/render/js_svg_test.clj
Loading
Please register or sign in to comment