-
- Downloads
Better handle numeric action parameters with "select" and "radio" types (#29000)
* Don't ignore manually entered parameters on clean * Validate options for numeric fields with dropdown input * Clear `valueOptions` when switching field and input types * Remove sample options for inputs with options * Rename `getValidationError` * Bring sample options back * Minor rename for clarity * Fix `InputOptionsMap` type * Keep `inputType` on field type change if possible * Extract `FieldValueOptions` type * Use less aggressive value options clean logic * Simplify tests * Test value options reset for option-less field types * Fix `OptionEditor` value gets out of sync
Showing
- frontend/src/metabase-types/api/actions.ts 3 additions, 1 deletionfrontend/src/metabase-types/api/actions.ts
- frontend/src/metabase/actions/components/ActionForm/ActionForm.unit.spec.tsx 1 addition, 0 deletions...se/actions/components/ActionForm/ActionForm.unit.spec.tsx
- frontend/src/metabase/actions/components/ActionForm/FormFieldEditor.tsx 35 additions, 6 deletions...etabase/actions/components/ActionForm/FormFieldEditor.tsx
- frontend/src/metabase/actions/components/ActionForm/FormFieldEditor.unit.spec.tsx 89 additions, 6 deletions...tions/components/ActionForm/FormFieldEditor.unit.spec.tsx
- frontend/src/metabase/actions/components/ActionForm/utils.ts 11 additions, 10 deletionsfrontend/src/metabase/actions/components/ActionForm/utils.ts
- frontend/src/metabase/actions/components/ActionViz/Action.tsx 4 additions, 4 deletions...tend/src/metabase/actions/components/ActionViz/Action.tsx
- frontend/src/metabase/actions/components/ActionViz/Action.unit.spec.tsx 6 additions, 6 deletions...etabase/actions/components/ActionViz/Action.unit.spec.tsx
- frontend/src/metabase/actions/containers/ActionCreator/FormCreator/FieldSettingsButtons.tsx 1 addition, 0 deletions...ainers/ActionCreator/FormCreator/FieldSettingsButtons.tsx
- frontend/src/metabase/actions/containers/ActionCreator/FormCreator/OptionEditor.styled.tsx 9 additions, 2 deletions...tainers/ActionCreator/FormCreator/OptionEditor.styled.tsx
- frontend/src/metabase/actions/containers/ActionCreator/FormCreator/OptionEditor.tsx 71 additions, 15 deletions...ons/containers/ActionCreator/FormCreator/OptionEditor.tsx
- frontend/src/metabase/actions/containers/ActionCreator/FormCreator/OptionEditor.unit.spec.tsx 107 additions, 0 deletions...ners/ActionCreator/FormCreator/OptionEditor.unit.spec.tsx
- frontend/src/metabase/actions/containers/ActionCreator/FormCreator/constants.ts 1 addition, 6 deletions...actions/containers/ActionCreator/FormCreator/constants.ts
Loading
Please register or sign in to comment