Skip to content
Snippets Groups Projects
Unverified Commit 8e206ae5 authored by Gustavo Saiani's avatar Gustavo Saiani Committed by GitHub
Browse files

Rename toggle event functions (#27241)

parent efacbdae
No related branches found
No related tags found
No related merge requests found
......@@ -52,7 +52,7 @@ const TimelineSidebar = ({
[onOpenModal],
);
const handleToggleEvent = useCallback(
const handleToggleEventSelected = useCallback(
(event: TimelineEvent, isSelected: boolean) => {
if (isSelected) {
onSelectTimelineEvents?.([event]);
......@@ -84,7 +84,7 @@ const TimelineSidebar = ({
onNewEvent={handleNewEvent}
onEditEvent={handleEditEvent}
onMoveEvent={handleMoveEvent}
onToggleEvent={handleToggleEvent}
onToggleEventSelected={handleToggleEventSelected}
onToggleTimeline={handleToggleTimeline}
/>
</SidebarContent>
......
......@@ -25,7 +25,7 @@ export interface EventCardProps {
onEdit?: (event: TimelineEvent) => void;
onMove?: (event: TimelineEvent) => void;
onArchive?: (event: TimelineEvent) => void;
onToggle?: (event: TimelineEvent, isSelected: boolean) => void;
onToggleSelected?: (event: TimelineEvent, isSelected: boolean) => void;
}
const EventCard = ({
......@@ -35,7 +35,7 @@ const EventCard = ({
onEdit,
onMove,
onArchive,
onToggle,
onToggleSelected,
}: EventCardProps): JSX.Element => {
const selectedRef = useScrollOnMount();
const menuItems = getMenuItems(event, timeline, onEdit, onMove, onArchive);
......@@ -43,8 +43,8 @@ const EventCard = ({
const creatorMessage = getCreatorMessage(event);
const handleEventClick = useCallback(() => {
onToggle?.(event, !isSelected);
}, [event, isSelected, onToggle]);
onToggleSelected?.(event, !isSelected);
}, [event, isSelected, onToggleSelected]);
const handleAsideClick = useCallback((event: SyntheticEvent) => {
event.stopPropagation();
......
......@@ -28,7 +28,7 @@ export interface TimelineCardProps {
onEditEvent?: (event: TimelineEvent) => void;
onMoveEvent?: (event: TimelineEvent) => void;
onArchiveEvent?: (event: TimelineEvent) => void;
onToggleEvent?: (event: TimelineEvent, isSelected: boolean) => void;
onToggleEventSelected?: (event: TimelineEvent, isSelected: boolean) => void;
onToggleTimeline?: (timeline: Timeline, isVisible: boolean) => void;
}
......@@ -40,7 +40,7 @@ const TimelineCard = ({
onEditEvent,
onMoveEvent,
onArchiveEvent,
onToggleEvent,
onToggleEventSelected,
onToggleTimeline,
}: TimelineCardProps): JSX.Element => {
const events = getEvents(timeline.events);
......@@ -62,15 +62,15 @@ const TimelineCard = ({
[timeline, onToggleTimeline],
);
const handleToggleEvent = useCallback(
const handleToggleEventSelected = useCallback(
(event: TimelineEvent, isSelected: boolean) => {
onToggleEvent?.(event, isSelected);
onToggleEventSelected?.(event, isSelected);
if (isSelected && !isVisible) {
onToggleTimeline?.(timeline, true);
}
},
[timeline, isVisible, onToggleTimeline, onToggleEvent],
[timeline, isVisible, onToggleTimeline, onToggleEventSelected],
);
useEffect(() => {
......@@ -105,7 +105,7 @@ const TimelineCard = ({
onEdit={onEditEvent}
onMove={onMoveEvent}
onArchive={onArchiveEvent}
onToggle={handleToggleEvent}
onToggleSelected={handleToggleEventSelected}
/>
))}
</CardContent>
......
......@@ -40,7 +40,7 @@ describe("TimelineCard", () => {
expect(props.onToggleTimeline).toHaveBeenCalled();
});
it("should make a timeline visible when its even is selected", () => {
it("should make a timeline visible when its event is selected", () => {
const props = getProps({
timeline: createMockTimeline({
name: "Releases",
......
......@@ -9,7 +9,7 @@ export interface TimelineListProps {
onEditEvent?: (event: TimelineEvent) => void;
onMoveEvent?: (event: TimelineEvent) => void;
onArchiveEvent?: (event: TimelineEvent) => void;
onToggleEvent?: (event: TimelineEvent, isSelected: boolean) => void;
onToggleEventSelected?: (event: TimelineEvent, isSelected: boolean) => void;
onToggleTimeline?: (timeline: Timeline, isVisible: boolean) => void;
}
......@@ -20,7 +20,7 @@ const TimelineList = ({
onEditEvent,
onMoveEvent,
onArchiveEvent,
onToggleEvent,
onToggleEventSelected,
onToggleTimeline,
}: TimelineListProps): JSX.Element => {
return (
......@@ -35,7 +35,7 @@ const TimelineList = ({
onToggleTimeline={onToggleTimeline}
onEditEvent={onEditEvent}
onMoveEvent={onMoveEvent}
onToggleEvent={onToggleEvent}
onToggleEventSelected={onToggleEventSelected}
onArchiveEvent={onArchiveEvent}
/>
))}
......
......@@ -15,7 +15,7 @@ export interface TimelinePanelProps {
onEditEvent?: (event: TimelineEvent) => void;
onMoveEvent?: (event: TimelineEvent) => void;
onArchiveEvent?: (event: TimelineEvent) => void;
onToggleEvent?: (event: TimelineEvent, isSelected: boolean) => void;
onToggleEventSelected?: (event: TimelineEvent, isSelected: boolean) => void;
onToggleTimeline?: (timeline: Timeline, isVisible: boolean) => void;
}
......@@ -28,7 +28,7 @@ const TimelinePanel = ({
onEditEvent,
onMoveEvent,
onArchiveEvent,
onToggleEvent,
onToggleEventSelected,
onToggleTimeline,
}: TimelinePanelProps): JSX.Element => {
const isEmpty = timelines.length === 0;
......@@ -49,7 +49,7 @@ const TimelinePanel = ({
onToggleTimeline={onToggleTimeline}
onEditEvent={onEditEvent}
onMoveEvent={onMoveEvent}
onToggleEvent={onToggleEvent}
onToggleEventSelected={onToggleEventSelected}
onArchiveEvent={onArchiveEvent}
/>
) : (
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment