Attach dashcard's viz settings to the card's :data :viz-settings key (#36067)
* Attach dashcard's viz settings to the card's :data :viz-settings key This flows through to the export format fn `metabase.email.messages/stream-api-results-to-export-format` Where it is then properly used. * Added test that gets the contents of .csv attachments Not sure yet why it's not working. Locally, with a real db id it works as expected, so it's on the right track. * Create a working test. * Card qp merges dashcard viz when it exists. Viz middleware normalizes card/dashcard viz-settings * Addressed feedback. - if viz settings map is empty in process viz settings middleware, use qp store. - now we don't have to do the (or ...) logic anywhere else - added comment in the test to try clarify what the 'viz' is setting up
Showing
- src/metabase/api/embed.clj 6 additions, 4 deletionssrc/metabase/api/embed.clj
- src/metabase/pulse.clj 6 additions, 9 deletionssrc/metabase/pulse.clj
- src/metabase/query_processor/card.clj 27 additions, 23 deletionssrc/metabase/query_processor/card.clj
- src/metabase/query_processor/middleware/visualization_settings.clj 16 additions, 14 deletions...ase/query_processor/middleware/visualization_settings.clj
- test/metabase/api/embed_test.clj 24 additions, 0 deletionstest/metabase/api/embed_test.clj
- test/metabase/dashboard_subscription_test.clj 55 additions, 1 deletiontest/metabase/dashboard_subscription_test.clj
Loading
Please register or sign in to comment