Simplify `createMockSettingsState` utility (#27546)

frontend/src/metabase-types/store/mocks/settings.ts

-import { SettingsState } from "metabase-types/store";
+import type { Settings } from "metabase-types/api";
+import type { SettingsState } from "metabase-types/store";
 import { createMockSettings } from "metabase-types/api/mocks";
 
 export const createMockSettingsState = (
-  opts?: Partial<SettingsState>,
+  opts?: Partial<Settings>,
 ): SettingsState => ({
-  values: createMockSettings(),
-  ...opts,
+  values: createMockSettings(opts),
 });

frontend/src/metabase/public/components/widgets/EmbedModalContent.unit.spec.tsx

@@ -3,7 +3,6 @@ import { screen, waitFor } from "@testing-library/react";
 import _ from "underscore";
 
 import { renderWithProviders } from "__support__/ui";
-import { createMockSettings } from "metabase-types/api/mocks";
 import { createMockSettingsState } from "metabase-types/store/mocks";
 
 import EmbedModalContent from "./EmbedModalContent";
@@ -145,10 +144,8 @@ function renderWithConfiguredProviders(element: JSX.Element) {
   renderWithProviders(element, {
     storeInitialState: {
       settings: createMockSettingsState({
-        values: createMockSettings({
-          "enable-embedding": true,
-          "embedding-secret-key": "my_super_secret_key",
-        }),
+        "enable-embedding": true,
+        "embedding-secret-key": "my_super_secret_key",
       }),
     },
   });

frontend/test/__support__/settings.ts

@@ -5,7 +5,7 @@ import type { Settings } from "metabase-types/api";
 
 export function mockSettings(params: Partial<Settings> = {}) {
   const settings = createMockSettings(params);
-  const state = createMockSettingsState({ values: settings });
+  const state = createMockSettingsState(settings);
 
   MetabaseSettings.setAll(settings);