embed-homepage - ms1 PR (#40382)
* create ui for the full embedding homepage, without any logic (#40251) * wip ui for the full embedding homepage * adds missing link + fix keys * remove done TODO * Update frontend/src/metabase/home/components/EmbedHomepage/InteractiveTabContent.tsx Co-authored-by:Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * destructure props in the function arguments * rename customerFacingAnalyticsDocsUrl to analyticsDocsUrl --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * add new settings for embedding homepage (#40455) * remove old minimal version * adds new embedding homepage settings and sets them at the end of the setup * comment e2e test * add tests for embedding homepage flags * more tests * remove unit tests related to old minimal version * fixes flags descriptions * :keyword for embedding-homepage Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * replace reloadSettings and refreshSettingsList with initializeSettings * `value => value === true` -> `Boolean` * toMatchObject -> toEqual for more strict tests * remove useless undefined check for settings, the component is conditionally rendered based on a setting so it means they're loaded anyway * fix: use :hidden as we changed the type to :keyword * specifically check for the `embedding` feature in the tokenFeatures object instead of checking if any feature is active * remove double \n Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> * connect settings to the embed homepage and show it (#40528) * fix nested a warnings in browser console * connect settings to the embed homepage and show it * fix stories * remove localStorage.clear() as we're not using it in the logic anymore * dismiss without feedback for the embedding homepage (#40587) * feat: add dismiss functionality to the embed homepage * update setup e2e to check for the dismissal of embedding homepage * use List from metabase/ui (#40638) * set embedding-secret-key when embedding is enabled (#40813) * set embedding-secret-key when embedding is enabled * use "named" setters and getters as suggested by Noah * Fix tests for ms1 after updating on master (#41069) --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
Showing
- e2e/snapshot-creators/default.cy.snap.js 7 additions, 4 deletionse2e/snapshot-creators/default.cy.snap.js
- e2e/test/scenarios/onboarding/setup/setup.cy.spec.ts 25 additions, 10 deletionse2e/test/scenarios/onboarding/setup/setup.cy.spec.ts
- frontend/src/metabase-types/api/mocks/settings.ts 3 additions, 0 deletionsfrontend/src/metabase-types/api/mocks/settings.ts
- frontend/src/metabase-types/api/settings.ts 8 additions, 0 deletionsfrontend/src/metabase-types/api/settings.ts
- frontend/src/metabase/admin/settings/selectors.js 1 addition, 17 deletionsfrontend/src/metabase/admin/settings/selectors.js
- frontend/src/metabase/home/components/EmbedHomepage/EmbedHomepage.stories.tsx 47 additions, 0 deletions...e/home/components/EmbedHomepage/EmbedHomepage.stories.tsx
- frontend/src/metabase/home/components/EmbedHomepage/EmbedHomepage.tsx 72 additions, 0 deletions.../metabase/home/components/EmbedHomepage/EmbedHomepage.tsx
- frontend/src/metabase/home/components/EmbedHomepage/EmbedHomepageView.tsx 128 additions, 0 deletions...abase/home/components/EmbedHomepage/EmbedHomepageView.tsx
- frontend/src/metabase/home/components/EmbedHomepage/InteractiveTabContent.tsx 73 additions, 0 deletions...e/home/components/EmbedHomepage/InteractiveTabContent.tsx
- frontend/src/metabase/home/components/EmbedHomepage/StaticTabContent.tsx 61 additions, 0 deletions...tabase/home/components/EmbedHomepage/StaticTabContent.tsx
- frontend/src/metabase/home/components/EmbedHomepage/index.ts 3 additions, 0 deletionsfrontend/src/metabase/home/components/EmbedHomepage/index.ts
- frontend/src/metabase/home/components/EmbedHomepage/tests/common.unit.spec.tsx 69 additions, 0 deletions.../home/components/EmbedHomepage/tests/common.unit.spec.tsx
- frontend/src/metabase/home/components/EmbedHomepage/tests/enterprise.unit.spec.tsx 33 additions, 0 deletions...e/components/EmbedHomepage/tests/enterprise.unit.spec.tsx
- frontend/src/metabase/home/components/EmbedHomepage/tests/premium.unit.spec.tsx 46 additions, 0 deletions...home/components/EmbedHomepage/tests/premium.unit.spec.tsx
- frontend/src/metabase/home/components/EmbedHomepage/tests/setup.tsx 51 additions, 0 deletions...rc/metabase/home/components/EmbedHomepage/tests/setup.tsx
- frontend/src/metabase/home/components/EmbedHomepage/types.ts 6 additions, 0 deletionsfrontend/src/metabase/home/components/EmbedHomepage/types.ts
- frontend/src/metabase/home/components/EmbedMinimalHomepage/EmbedMinimalHomepage.styled.tsx 0 additions, 6 deletions...ents/EmbedMinimalHomepage/EmbedMinimalHomepage.styled.tsx
- frontend/src/metabase/home/components/EmbedMinimalHomepage/EmbedMinimalHomepage.tsx 0 additions, 73 deletions.../components/EmbedMinimalHomepage/EmbedMinimalHomepage.tsx
- frontend/src/metabase/home/components/EmbedMinimalHomepage/index.ts 0 additions, 1 deletion...rc/metabase/home/components/EmbedMinimalHomepage/index.ts
- frontend/src/metabase/home/components/HomeContent/HomeContent.tsx 10 additions, 23 deletions.../src/metabase/home/components/HomeContent/HomeContent.tsx
Loading
Please register or sign in to comment