Ensure Setting :default values match the Setting :type; fix user-facing-value...
Ensure Setting :default values match the Setting :type; fix user-facing-value for calculated Settings. Cleanup & extra tests for email settings (#17442) * Change of plans. get-string (etc) only return default if it matches the type * Better docstrings * More tests & rework the validate-default-value logic a bit. * Fix lint error * Add an additional test for GET /api/setting * Consolidate exception-chain util functions * Email error message humanization improvements * More tests for util ex-chain * Clean up email error handling and add lots of extra tests * Fix docstring indentation * Even more email tests * Test fixes* Update Cypress test again * Code cleanup
Showing
- frontend/test/metabase/scenarios/admin/settings/email.cy.spec.js 1 addition, 1 deletion...d/test/metabase/scenarios/admin/settings/email.cy.spec.js
- src/metabase/api/email.clj 27 additions, 22 deletionssrc/metabase/api/email.clj
- src/metabase/api/ldap.clj 2 additions, 3 deletionssrc/metabase/api/ldap.clj
- src/metabase/email.clj 90 additions, 68 deletionssrc/metabase/email.clj
- src/metabase/integrations/ldap.clj 21 additions, 15 deletionssrc/metabase/integrations/ldap.clj
- src/metabase/models/humanization.clj 13 additions, 11 deletionssrc/metabase/models/humanization.clj
- src/metabase/models/setting.clj 122 additions, 44 deletionssrc/metabase/models/setting.clj
- src/metabase/public_settings.clj 12 additions, 6 deletionssrc/metabase/public_settings.clj
- src/metabase/query_processor/middleware/catch_exceptions.clj 4 additions, 9 deletionssrc/metabase/query_processor/middleware/catch_exceptions.clj
- src/metabase/task/send_pulses.clj 2 additions, 2 deletionssrc/metabase/task/send_pulses.clj
- src/metabase/troubleshooting.clj 2 additions, 2 deletionssrc/metabase/troubleshooting.clj
- src/metabase/util.clj 3 additions, 2 deletionssrc/metabase/util.clj
- test/metabase/api/email_test.clj 69 additions, 17 deletionstest/metabase/api/email_test.clj
- test/metabase/api/session_test.clj 5 additions, 3 deletionstest/metabase/api/session_test.clj
- test/metabase/api/setting_test.clj 20 additions, 3 deletionstest/metabase/api/setting_test.clj
- test/metabase/email/messages_test.clj 18 additions, 21 deletionstest/metabase/email/messages_test.clj
- test/metabase/email_test.clj 4 additions, 4 deletionstest/metabase/email_test.clj
- test/metabase/integrations/ldap_test.clj 1 addition, 1 deletiontest/metabase/integrations/ldap_test.clj
- test/metabase/models/setting_test.clj 56 additions, 4 deletionstest/metabase/models/setting_test.clj
- test/metabase/test/integrations/ldap.clj 1 addition, 1 deletiontest/metabase/test/integrations/ldap.clj
Loading
Please register or sign in to comment