-
- Downloads
Fetch and use fields associated with a parameter to parse parameter values...
Fetch and use fields associated with a parameter to parse parameter values found in URL query (#18104) * move logic in dashboard selectors to meta/Dashboard * rmv usage of syncQueryParamsWithURL * add syncQueryParamsWithURL logic to meta/Parameters.js * Fix public questions * fix dashboards * fix query builder * don't normalize when value is empty string * rmv unused setMultipleParameterValues fn * replace selector logic with meta/Dashboard fn * filter out nil fields we need to do more work before we can properly use fields from nested questions when parsing parameter values. * add field to dash parameter so we can correctly type nested native query fields * fix tests * code style tweaks per review
Showing
- frontend/src/metabase/dashboard/actions.js 19 additions, 3 deletionsfrontend/src/metabase/dashboard/actions.js
- frontend/src/metabase/dashboard/selectors.js 8 additions, 118 deletionsfrontend/src/metabase/dashboard/selectors.js
- frontend/src/metabase/dashboard/selectors.unit.spec.js 7 additions, 1 deletionfrontend/src/metabase/dashboard/selectors.unit.spec.js
- frontend/src/metabase/meta/Dashboard.js 143 additions, 3 deletionsfrontend/src/metabase/meta/Dashboard.js
- frontend/src/metabase/meta/Parameter.js 79 additions, 5 deletionsfrontend/src/metabase/meta/Parameter.js
- frontend/src/metabase/parameters/components/Parameters/Parameters.jsx 0 additions, 7 deletions.../metabase/parameters/components/Parameters/Parameters.jsx
- frontend/src/metabase/parameters/components/Parameters/syncQueryParamsWithURL.js 0 additions, 116 deletions...arameters/components/Parameters/syncQueryParamsWithURL.js
- frontend/src/metabase/public/components/EmbedFrame.jsx 0 additions, 5 deletionsfrontend/src/metabase/public/components/EmbedFrame.jsx
- frontend/src/metabase/public/containers/PublicQuestion.jsx 2 additions, 14 deletionsfrontend/src/metabase/public/containers/PublicQuestion.jsx
- frontend/src/metabase/query_builder/actions.js 15 additions, 2 deletionsfrontend/src/metabase/query_builder/actions.js
- frontend/src/metabase/query_builder/containers/QueryBuilder.jsx 5 additions, 1 deletion...nd/src/metabase/query_builder/containers/QueryBuilder.jsx
- frontend/src/metabase/query_builder/reducers.js 3 additions, 0 deletionsfrontend/src/metabase/query_builder/reducers.js
- frontend/test/metabase/meta/Dashboard.unit.spec.js 136 additions, 0 deletionsfrontend/test/metabase/meta/Dashboard.unit.spec.js
- frontend/test/metabase/meta/Parameter.unit.spec.js 379 additions, 52 deletionsfrontend/test/metabase/meta/Parameter.unit.spec.js
- frontend/test/metabase/meta/dashboard-with-boolean-parameter.json 385 additions, 0 deletions.../test/metabase/meta/dashboard-with-boolean-parameter.json
- frontend/test/metabase/parameters/components/Parameters/syncQueryParamsWithURL.unit.spec.js 0 additions, 247 deletions...components/Parameters/syncQueryParamsWithURL.unit.spec.js
Loading
Please register or sign in to comment