Skip to content
Snippets Groups Projects
Unverified Commit 95cd7f25 authored by Cam Saul's avatar Cam Saul Committed by GitHub
Browse files

Fix CircleCI job skipping magic: `$CIRCLE_STAGE` has been renamed to `$CIRCLE_JOB` (#24128)

* Fix CircleCI job skipping magic: `$CIRCLE_STAGE` has been renamed to `$CIRCLE_JOB`

* Bust cache if `$CIRCLE_JOB` is unset

* Print message if `$CIRCLE_JOB` is unset and we're busting the cache

* Fix GoogleAnalytics status code
parent 26371064
No related merge requests found
......@@ -254,9 +254,9 @@ cache-key-backend-deps: &CacheKeyBackendDeps
key: v5-{{ checksum ".CACHE-PREFIX" }}-be-deps-{{ checksum "deps.edn" }}-{{ checksum ".SCRIPTS-DEPS-CHECKSUMS" }}
# Key used for implementation of run-on-change -- this is the cache key that contains the .SUCCESS dummy file
# By default the key ALWAYS includes the name of the test job itself ($CIRCLE_STAGE) so you don't need to add that yourself.
# By default the key ALWAYS includes the name of the test job itself ($CIRCLE_JOB) so you don't need to add that yourself.
cache-key-run-on-change: &CacheKeyRunOnChange
key: v5-{{ checksum ".CACHE-PREFIX" }}-run-on-change-{{ .Environment.CIRCLE_STAGE }}-<< parameters.checksum >>
key: v5-{{ checksum ".CACHE-PREFIX" }}-run-on-change-{{ .Environment.CIRCLE_JOB }}-<< parameters.checksum >>
########################################################################################################################
# COMMANDS #
......@@ -494,6 +494,13 @@ jobs:
else
echo '' > .CACHE-PREFIX
fi
- run:
name: 'If $CIRCLE_JOB is unset then bust the cache (see #24128 for details)'
command: |
if [ -z "$CIRCLE_JOB" ]; then
echo '$CIRCLE_JOB is unset. Using cache-busting prefix.'
echo '<< pipeline.id >>' > .CACHE-PREFIX
fi
- run:
name: Create static visualization js bundle
command: yarn build-static-viz
......@@ -502,7 +509,7 @@ jobs:
command: |
if [[ $CIRCLE_BRANCH == release* || $CIRCLE_BRANCH == master ]]; then
echo 'This is a release or master branch; using cache-busting prefix'
echo '<< pipeline.id >>' > .CACHE-PREFIX
echo '<< pipeline.id >>' > .CACHE-PREFIX
fi
- run:
name: Make SSL certificates for Mongo available
......
......@@ -360,7 +360,7 @@
Table [table {:db_id (u/the-id db)}]
Field [field {:table_id (u/the-id table)}]]
(let [cnt (->> (mt/user-http-request
:crowberto :post 202 "card"
:crowberto :post 200 "card"
{:name "Metabase Websites, Sessions and 1 Day Active Users, Grouped by Date (day)"
:display :table
:visualization_settings {}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment