Skip to content
Snippets Groups Projects
Unverified Commit 964a8040 authored by Anton Kulyk's avatar Anton Kulyk Committed by GitHub
Browse files

Make it more difficult to change Site URL (#15849)

* Change site-url description copy

* Display part of site-url description as bold text

* Replace custom description with warningMessage prop
parent 8a596208
No related branches found
No related tags found
No related merge requests found
...@@ -7,6 +7,11 @@ const SettingHeader = ({ setting }) => ( ...@@ -7,6 +7,11 @@ const SettingHeader = ({ setting }) => (
{setting.display_name} {setting.display_name}
</div> </div>
<div className="text-medium text-measure my1"> <div className="text-medium text-measure my1">
{setting.warningMessage && (
<React.Fragment>
<strong>{setting.warningMessage}</strong>{" "}
</React.Fragment>
)}
{setting.description} {setting.description}
{setting.note && <div>{setting.note}</div>} {setting.note && <div>{setting.note}</div>}
</div> </div>
......
...@@ -65,6 +65,7 @@ const SECTIONS = updateSectionsWithPlugins({ ...@@ -65,6 +65,7 @@ const SECTIONS = updateSectionsWithPlugins({
display_name: t`Site URL`, display_name: t`Site URL`,
type: "string", type: "string",
widget: SiteUrlWidget, widget: SiteUrlWidget,
warningMessage: t`Only change this if you know what you're doing!`,
}, },
{ {
key: "redirect-all-requests-to-https", key: "redirect-all-requests-to-https",
......
...@@ -86,7 +86,9 @@ ...@@ -86,7 +86,9 @@
;; This value is *guaranteed* to never have a trailing slash :D ;; This value is *guaranteed* to never have a trailing slash :D
;; It will also prepend `http://` to the URL if there's no protocol when it comes in ;; It will also prepend `http://` to the URL if there's no protocol when it comes in
(defsetting site-url (defsetting site-url
(deferred-tru "The base URL of this Metabase instance, e.g. \"http://metabase.my-company.com\".") (str (deferred-tru "This URL is used for things like creating links in emails, auth redirects,")
" "
(deferred-tru "and in some embedding scenarios, so changing it could break functionality or get you locked out of this instance."))
:visibility :public :visibility :public
:getter (fn [] :getter (fn []
(try (try
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment