Fix adding a filter for a UUID PK column (#40777)

e2e/support/test_tables.js

@@ -102,6 +102,24 @@ export const many_data_types = async dbClient => {
   return null;
 };
 
+export const uuid_pk_table = async dbClient => {
+  const tableName = "uuid_pk_table";
+
+  await dbClient.schema.dropTableIfExists(tableName);
+
+  await dbClient.schema.createTable(tableName, table => {
+    table.uuid("id").primary();
+    table.string("name");
+  });
+
+  await dbClient(tableName).insert([
+    { id: "a0eebc99-9c0b-4ef8-bb6d-6bb9bd380a11", name: "Duck" },
+    { id: "a0eebc99-9c0b-4ef8-bb6d-6bb9bd380a12", name: "Rabbit" },
+  ]);
+
+  return null;
+};
+
 export const composite_pk_table = async dbClient => {
   const tableName = "composite_pk_table";
 

e2e/test/scenarios/question/reproductions/40176-uuid-column-filter.cy.spec.js

+import { WRITABLE_DB_ID } from "e2e/support/cypress_data";
+import {
+  getTable,
+  openNotebook,
+  popover,
+  resetTestTable,
+  restore,
+  resyncDatabase,
+  visitQuestionAdhoc,
+  visualize,
+} from "e2e/support/helpers";
+
+const DIALECT = "postgres";
+const TABLE = "uuid_pk_table";
+
+describe("issue 40176", () => {
+  beforeEach(() => {
+    restore(`${DIALECT}-writable`);
+    cy.signInAsAdmin();
+    resetTestTable({ type: DIALECT, table: TABLE });
+    resyncDatabase({
+      dbId: WRITABLE_DB_ID,
+      tableName: TABLE,
+    });
+  });
+
+  it(
+    "should allow filtering on UUID PK columns (metabase#40176)",
+    { tags: "@external" },
+    () => {
+      getTable({ name: TABLE }).then(({ id: tableId }) => {
+        visitQuestionAdhoc({
+          display: "table",
+          dataset_query: {
+            database: WRITABLE_DB_ID,
+            query: {
+              "source-table": tableId,
+            },
+            type: "query",
+          },
+        });
+      });
+      openNotebook();
+      cy.findByTestId("action-buttons").findByText("Filter").click();
+      popover().within(() => {
+        cy.findByText("ID").click();
+        cy.findByLabelText("Filter value").type(
+          "a0eebc99-9c0b-4ef8-bb6d-6bb9bd380a11",
+        );
+        cy.button("Add filter").click();
+      });
+      visualize();
+      cy.findByTestId("question-row-count")
+        .findByText("Showing 1 row")
+        .should("be.visible");
+    },
+  );
+});

src/metabase/api/field.clj

@@ -403,7 +403,7 @@
       (get-in results [:data :rows]))
     (catch Throwable e
       (log/error e (trs "Error searching field values"))
-      nil))))
+      []))))
 
 (api/defendpoint GET "/:id/search/:search-id"
   "Search for values of a Field with `search-id` that start with `value`. See docstring for