-
- Downloads
Static Viz and Exports/Downloads Respect Dashcard Viz Settings (#45164)
* start adding some util fns to download-exports-test ns * wip improving test util fns * add subscription attachment util fn * add tests to catch download/export differences * viz-settings from card and dashcard merged properly * revert these changes which probably aren't needed * split test: downloads can be parallel, email attachments cannot * normalize viz-settings no matter their origin * Update test/metabase/api/downloads_exports_test.clj Co-authored-by:Alexander Solovyov <alexander@solovyov.net> * Incorporate some review feedback * rendered table cards also respect column names * Clean up table render tests and remove unhelpful render test utils The big removal of code in the render test utils namespace is a clean up task that could've happened sooner, but this table test adjustment is the perfect opportunity to clean up. I had made the test utils before I truly knew how best to use `mt/with-temp`, so it had a lot of poorly implemented 'generators' that were doing a poor job of creating mock data for the rendering functions anyway. So, reworking a few table tests here to just use a temp card is way more inline with the rest of the codebase, and actually improves confidence that the tests are testing on well-formed data to begin with. --------- Co-authored-by:
Alexander Solovyov <alexander@solovyov.net>
Showing
- src/metabase/pulse/render.clj 0 additions, 7 deletionssrc/metabase/pulse/render.clj
- src/metabase/pulse/render/body.clj 3 additions, 2 deletionssrc/metabase/pulse/render/body.clj
- src/metabase/pulse/render/table.clj 17 additions, 10 deletionssrc/metabase/pulse/render/table.clj
- src/metabase/query_processor/card.clj 27 additions, 25 deletionssrc/metabase/query_processor/card.clj
- src/metabase/query_processor/middleware/visualization_settings.clj 5 additions, 4 deletions...ase/query_processor/middleware/visualization_settings.clj
- test/metabase/api/downloads_exports_test.clj 173 additions, 0 deletionstest/metabase/api/downloads_exports_test.clj
- test/metabase/pulse/render/body_test.clj 32 additions, 0 deletionstest/metabase/pulse/render/body_test.clj
- test/metabase/pulse/render/table_test.clj 73 additions, 141 deletionstest/metabase/pulse/render/table_test.clj
- test/metabase/pulse/render/test_util.clj 3 additions, 420 deletionstest/metabase/pulse/render/test_util.clj
Loading
Please register or sign in to comment