Skip to content
Snippets Groups Projects
Unverified Commit 98223738 authored by Cal Herries's avatar Cal Herries Committed by GitHub
Browse files

Remove support for nested-field-columns feature for redshift (#29465)

* Drop support for nested field columns for redshift

* db/select -> t2/select

* Remove clj_kondo file
parent a967a464
No related branches found
No related tags found
No related merge requests found
......@@ -30,9 +30,9 @@
(driver/register! :redshift, :parent #{:postgres ::sql-jdbc.legacy/use-legacy-classes-for-read-and-set})
(defmethod driver/database-supports? [:redshift :test/jvm-timezone-setting]
[_driver _feature _database]
false)
(doseq [[feature supported?] {:test/jvm-timezone-setting false
:nested-field-columns false}]
(defmethod driver/database-supports? [:redshift feature] [_driver _feat _db] supported?))
;;; +----------------------------------------------------------------------------------------------------------------+
;;; | metabase.driver impls |
......
......@@ -223,7 +223,7 @@
(mt/with-temp* [PermissionsGroup [group]]
(mt/user-http-request :crowberto :put 200 "permissions/graph"
(assoc-in (perms/data-perms-graph) [:groups (u/the-id group)] nil))
(is (empty? (db/select :permissions :group_id (u/the-id group))))
(is (empty? (t2/select :permissions :group_id (u/the-id group))))
(is (= nil (get-in (perms/data-perms-graph) [:groups (u/the-id group)])))
(is (= nil (get-in (perms/data-perms-graph-v2) [:groups (u/the-id group)])))))))
......@@ -240,14 +240,14 @@
"/query/db/%s/schema/PUBLIC/table/%s/"
"/db/%s/schema/PUBLIC/table/%s/"]]
(format template (mt/id) db-id)))
(set (mapv :object (db/select :permissions :group_id (u/the-id group))))))
(set (mapv :object (t2/select :permissions :group_id (u/the-id group))))))
(mt/user-http-request
:crowberto :put 200 "permissions/graph"
(assoc-in (perms/data-perms-graph)
[:groups (u/the-id group) (mt/id)]
{:data {:native "none" :schemas "none"}}))
(is (= #{}
(set (mapv :object (db/select :permissions :group_id (u/the-id group)))))))))))
(set (mapv :object (t2/select :permissions :group_id (u/the-id group)))))))))))
(deftest update-perms-graph-error-test
(testing "PUT /api/permissions/graph"
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment