Skip to content
Snippets Groups Projects
Unverified Commit 98b5cb7a authored by dpsutton's avatar dpsutton Committed by GitHub
Browse files

Check columns for datetime behavior based on special_type (#15319)

master has a semantic_type that this should be updated to when
merged. Or even better, if columns have an effective type we can just
use that. I'm not sure how inference goes so it may just have a
base_type that is the datetime type if its just inferred, or if the
column is recognized as a field maybe it has both base and effective
types
parent 1a72347c
Branches
Tags
No related merge requests found
......@@ -14,7 +14,9 @@ import type {
function getFiltersForColumn(column) {
if (
isa(column.base_type, TYPE.Number) ||
isa(column.base_type, TYPE.Temporal)
isa(column.base_type, TYPE.Temporal) ||
// change to semantic_type or ideally effective_type if that is known after merging into master
isa(column.special_type, TYPE.Temporal)
) {
return [
{ name: "<", operator: "<" },
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment