Skip to content
Snippets Groups Projects
Unverified Commit 9ae66ab7 authored by Emmad Usmani's avatar Emmad Usmani Committed by GitHub
Browse files

fix dashboard opening in editing state when it shouldn't (#29368)

* fix dashboard opening in editing state when it shouldn't

* unskip reproduction test
parent c892b4b4
No related branches found
No related tags found
No related merge requests found
......@@ -5,7 +5,7 @@ import {
saveDashboard,
} from "e2e/support/helpers";
describe.skip("issue 26826", () => {
describe("issue 26826", () => {
beforeEach(() => {
restore();
cy.signInAsAdmin();
......
......@@ -109,12 +109,11 @@ const mapDispatchToProps = {
// NOTE: should use DashboardControls and DashboardData HoCs here?
const DashboardApp = props => {
const options = parseHashOptions(window.location.hash);
const { isRunning, isLoadingComplete, dashboard } = props;
const [editingOnLoad] = useState(options.edit);
const [addCardOnLoad] = useState(options.add && parseInt(options.add));
const options = parseHashOptions(window.location.hash);
const editingOnLoad = options.edit;
const addCardOnLoad = options.add && parseInt(options.add);
const [isShowingToaster, setIsShowingToaster] = useState(false);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment