Allow creating actions with "+ New" button (#28419)
* Make `modelId` optional in `ActionCreator` * Add `onSubmit` prop to `ActionCreator` * Allow creating actions with "+ New" button * Add `nock.cleanAll()` * Address comments * Use `CollectionItem` type * Use `import type` * Enable loading and error wrapper for loader
Showing
- frontend/src/metabase/actions/containers/ActionCreator/ActionCreator.tsx 15 additions, 7 deletions...tabase/actions/containers/ActionCreator/ActionCreator.tsx
- frontend/src/metabase/components/NewItemMenu/NewItemMenu.tsx 36 additions, 2 deletionsfrontend/src/metabase/components/NewItemMenu/NewItemMenu.tsx
- frontend/src/metabase/containers/NewItemMenu/NewItemMenu.tsx 22 additions, 4 deletionsfrontend/src/metabase/containers/NewItemMenu/NewItemMenu.tsx
- frontend/src/metabase/containers/NewItemMenu/NewItemMenu.unit.spec.tsx 102 additions, 0 deletions...metabase/containers/NewItemMenu/NewItemMenu.unit.spec.tsx
- frontend/src/metabase/lib/urls/models.ts 1 addition, 1 deletionfrontend/src/metabase/lib/urls/models.ts
- frontend/src/metabase/nav/components/NewItemButton/NewItemButton.tsx 1 addition, 1 deletion...c/metabase/nav/components/NewItemButton/NewItemButton.tsx
- frontend/src/metabase/selectors/data.ts 6 additions, 0 deletionsfrontend/src/metabase/selectors/data.ts
- frontend/test/metabase/scenarios/models/model-actions.cy.spec.js 26 additions, 0 deletions...d/test/metabase/scenarios/models/model-actions.cy.spec.js
Loading
Please register or sign in to comment