-
- Downloads
Remove `:foreign-keys` feature or convert to `:metadata/key-constraints` where appropriate (#44894)
* Post sync hook stub for implicit joins testing stub * Add join alias to field lvalues to enable sorting on joined fields * Disable :foreign-keys on Mongo * Require :left-join support for implicit joins instead of :foreign-keys * Update implicit joins tests * Adjust sync-fields-test * Update implicit joins feature check test * Transform post-sync-hook to normal function * Add foreign key relationships only for dbmses without :foreign-keys feature * Update test to handle Oracle correctly * Split convoluted fn * Avoid unnecessary computations for datasets with no fks * Update docstring * Fix driver usage * Transform :foreign-keys to :metadata/key-constraints in test data loading code * Update sync_test.clj * Update driver_test.clj * Update moviedb.clj * Update dataset_definition_test.clj * Update fetch_metadata.clj * Update fields_test.clj * Update driver.clj * Update driver/sql.clj * Set sql driver join support to true for all joins Deriving drivers are expected to set to false where applicable. * Update sqllite.clj * Remove foreign-keys from spark * Remove :foreign-keys from presto * Remove :foreign-keys from Athena * Remove foreign-keys from big query Reading docs it seems fk inference should be ok. Let's see the test results. Act based on that. * Update test_metadata.cljc * Set key-constraints to false for bigquery * Add foreign keys to sqlite manually until sync is fixed * Return driver require to Athena * Correct typo * Add naive primary key heuristic * Update pk fk logic to handle name components correctly * Add alias escaping to presto * Add ordering to test * Add order by to test * Update test * Remove use of rewrite-fields-to-force-using-column-aliases in order by fields * Add exception to alias forcing * Different approach to exception from alias forcing * Alternative approach for prefixing idents in bigq * All seelcted fields by desired alias * Rewrite only fields not from this source table * Update test * Enable breakout-on-fk-field-test for :left-join drivers * Add feature comment * Explicit joins tests foreign-keys removal * Update nested_queries_test.clj * Update remapping tests * Update tests * Update tests to handle sqlite results format * Disable metadata/key-constraints on sqlite during tests until * Address remarks * Remove mt/with-mock-fks-for-drivers-without-fk-constraints * Update bigquery test * Update tests * Adjust row level restrictions * Add parameterized-sql feature * Update comment * Update leftovers * Order keys * Remove foreign keys from frontend * Fix FE unit * Update driver changelog * Address review remark * Update test/metabase/query_processor/test_util.clj Co-authored-by:metamben <103100869+metamben@users.noreply.github.com> * Update docs/developers-guide/driver-changelog.md Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Update docs/developers-guide/driver-changelog.md Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Update modules/drivers/bigquery-cloud-sdk/src/metabase/driver/bigquery_cloud_sdk/query_processor.clj Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Update docs/developers-guide/driver-changelog.md Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Update test * Update comment and reduce expression * Update comment * Address remarks * Fix merge --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
Showing
- docs/developers-guide/driver-changelog.md 8 additions, 0 deletionsdocs/developers-guide/driver-changelog.md
- enterprise/backend/test/metabase_enterprise/sandbox/query_processor/middleware/row_level_restrictions_test.clj 33 additions, 32 deletions...uery_processor/middleware/row_level_restrictions_test.clj
- enterprise/backend/test/metabase_enterprise/serialization/load_test.clj 99 additions, 100 deletions...kend/test/metabase_enterprise/serialization/load_test.clj
- frontend/src/metabase-lib/v1/expressions/__support__/expressions.ts 0 additions, 1 deletion...rc/metabase-lib/v1/expressions/__support__/expressions.ts
- frontend/src/metabase-lib/v1/expressions/suggest.unit.spec.ts 1 addition, 5 deletions...tend/src/metabase-lib/v1/expressions/suggest.unit.spec.ts
- frontend/src/metabase-types/api/database.ts 0 additions, 1 deletionfrontend/src/metabase-types/api/database.ts
- frontend/src/metabase-types/api/mocks/database.ts 0 additions, 1 deletionfrontend/src/metabase-types/api/mocks/database.ts
- frontend/src/metabase/nav/components/search/SearchBar/SearchBar.styled.tsx 0 additions, 1 deletion...base/nav/components/search/SearchBar/SearchBar.styled.tsx
- frontend/test/metabase/lib/expressions/resolver.unit.spec.js 1 addition, 1 deletionfrontend/test/metabase/lib/expressions/resolver.unit.spec.js
- modules/drivers/athena/src/metabase/driver/athena.clj 0 additions, 1 deletionmodules/drivers/athena/src/metabase/driver/athena.clj
- modules/drivers/athena/test/metabase/test/data/athena.clj 0 additions, 4 deletionsmodules/drivers/athena/test/metabase/test/data/athena.clj
- modules/drivers/bigquery-cloud-sdk/src/metabase/driver/bigquery_cloud_sdk.clj 2 additions, 3 deletions...uery-cloud-sdk/src/metabase/driver/bigquery_cloud_sdk.clj
- modules/drivers/bigquery-cloud-sdk/src/metabase/driver/bigquery_cloud_sdk/query_processor.clj 22 additions, 2 deletions...rc/metabase/driver/bigquery_cloud_sdk/query_processor.clj
- modules/drivers/bigquery-cloud-sdk/test/metabase/driver/bigquery_cloud_sdk/query_processor_test.clj 38 additions, 43 deletions...tabase/driver/bigquery_cloud_sdk/query_processor_test.clj
- modules/drivers/bigquery-cloud-sdk/test/metabase/driver/bigquery_cloud_sdk_test.clj 63 additions, 64 deletions...loud-sdk/test/metabase/driver/bigquery_cloud_sdk_test.clj
- modules/drivers/bigquery-cloud-sdk/test/metabase/test/data/bigquery_cloud_sdk.clj 0 additions, 16 deletions...-cloud-sdk/test/metabase/test/data/bigquery_cloud_sdk.clj
- modules/drivers/mongo/src/metabase/driver/mongo/query_processor.clj 15 additions, 9 deletions...ivers/mongo/src/metabase/driver/mongo/query_processor.clj
- modules/drivers/mongo/test/metabase/driver/mongo_test.clj 9 additions, 6 deletionsmodules/drivers/mongo/test/metabase/driver/mongo_test.clj
- modules/drivers/presto-jdbc/src/metabase/driver/presto_jdbc.clj 8 additions, 1 deletion...s/drivers/presto-jdbc/src/metabase/driver/presto_jdbc.clj
- modules/drivers/presto-jdbc/test/metabase/test/data/presto_jdbc.clj 0 additions, 4 deletions...ivers/presto-jdbc/test/metabase/test/data/presto_jdbc.clj
Loading
Please register or sign in to comment