Skip to content
Snippets Groups Projects
Unverified Commit 9e026ac0 authored by Anton Kulyk's avatar Anton Kulyk Committed by GitHub
Browse files

Display datasets in recent searches and on activity page (#18987)

* Display dataset model name in recent searches

* Fix dataset URLs in activity

* Fix icons in activity recent views

* Distinguish datesets from questions in activity

* Fix message
parent 0a83bd3c
No related branches found
No related tags found
No related merge requests found
......@@ -152,7 +152,9 @@ export default class Activity extends Component {
if (item.table) {
description.summary = (
<span>
{t`saved a question about `}
{item.model === "dataset"
? t`saved a dataset based on `
: t`saved a question about `}
<Link
to={Urls.tableRowsQuery(item.database_id, item.table_id)}
data-metabase-event={
......@@ -165,11 +167,15 @@ export default class Activity extends Component {
</span>
);
} else {
description.summary = t`saved a question`;
description.summary =
item.model === "dataset" ? t`saved a dataset` : t`saved a question`;
}
break;
case "card-delete":
description.summary = t`deleted a question`;
description.summary =
item.model === "dataset"
? t`deleted a dataset`
: t`deleted a question`;
break;
case "dashboard-create":
description.summary = t`created a dashboard`;
......
......@@ -29,6 +29,10 @@ export default class RecentViews extends Component {
return model_object.display;
} else if (model === "dashboard") {
return "dashboard";
} else if (model === "dataset") {
return "dataset";
} else if (model === "table") {
return "database";
} else {
return null;
}
......
......@@ -98,6 +98,10 @@ export function newQuestion({ mode, creationType, ...options } = {}) {
}
}
export function dataset(...args) {
return question(...args);
}
export function dashboard(dashboard, { addCardWithId, editMode } = {}) {
const options = {
...(addCardWithId ? { add: addCardWithId } : {}),
......@@ -125,6 +129,8 @@ export function modelToUrl(item) {
switch (item.model) {
case "card":
return question(modelData);
case "dataset":
return dataset(modelData);
case "dashboard":
return dashboard(modelData);
case "pulse":
......
......@@ -2,6 +2,7 @@ import { t } from "ttag";
const TRANSLATED_NAME_BY_MODEL_TYPE = {
card: t`Question`,
dataset: t`Dataset`,
dashboard: t`Dashboard`,
table: t`Table`,
database: t`Database`,
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment