Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
9e08c3e9
Unverified
Commit
9e08c3e9
authored
8 months ago
by
Chris Truter
Committed by
GitHub
8 months ago
Browse files
Options
Downloads
Patches
Plain Diff
Improve Query Analysis sweeper scheduling (#47064)
parent
0ec737a7
Branches
Branches containing commit
Tags
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
src/metabase/task.clj
+10
-1
10 additions, 1 deletion
src/metabase/task.clj
src/metabase/task/sweep_query_analysis.clj
+14
-9
14 additions, 9 deletions
src/metabase/task/sweep_query_analysis.clj
with
24 additions
and
10 deletions
src/metabase/task.clj
+
10
−
1
View file @
9e08c3e9
...
...
@@ -224,8 +224,17 @@
(
log/debug
"Job already exists:"
(
->
^
JobDetail
job
.getKey
.getName
))
(
reschedule-task!
job
trigger
)))))
(
mu/defn
trigger-now!
"Immediatley trigger exeuction of task"
[
job-key
:-
(
ms/InstanceOfClass
JobKey
)]
(
try
(
when-let
[
scheduler
(
scheduler
)]
(
.triggerJob
scheduler
job-key
))
(
catch
Throwable
e
(
log/errorf
e
"Failed to trigger immediate execution of task %s"
job-key
))))
(
mu/defn
delete-task!
"
d
elete a task from the scheduler"
"
D
elete a task from the scheduler"
[
job-key
:-
(
ms/InstanceOfClass
JobKey
)
trigger-key
:-
(
ms/InstanceOfClass
TriggerKey
)]
(
when-let
[
scheduler
(
scheduler
)]
(
qs/delete-trigger
scheduler
trigger-key
)
...
...
This diff is collapsed.
Click to expand it.
src/metabase/task/sweep_query_analysis.clj
+
14
−
9
View file @
9e08c3e9
...
...
@@ -87,17 +87,22 @@
(
sweep-query-analysis-loop!
)))
(
defmethod
task/init!
::SweepQueryAnalysis
[
_
]
(
let
[
job
(
jobs/build
(
let
[
job-key
(
jobs/key
"metabase.task.backfill-query-fields.job"
)
job
(
jobs/build
(
jobs/of-type
SweepQueryAnalysis
)
(
jobs/with-identity
(
jobs/key
"metabase.task.backfill-query-fields.job"
))
(
jobs/store-durably
))
(
jobs/with-identity
job-key
)
(
jobs/store-durably
)
(
jobs/request-recovery
))
trigger
(
triggers/build
(
triggers/with-identity
(
triggers/key
"metabase.task.backfill-query-fields.trigger"
))
(
triggers/start-now
)
(
triggers/with-schedule
(
cron/schedule
(
cron/cron-schedule
;; run every 4 hours at a random minute:
(
format
"0 %d 0/4 1/1 * ? *"
(
rand-int
60
)))
(
cron/with-misfire-handling-instruction-do-nothing
))))]
(
task/schedule-task!
job
trigger
)))
(
cron/schedule
(
cron/cron-schedule
;; run every 4 hours at a random minute:
(
format
"0 %d 0/4 1/1 * ? *"
(
rand-int
60
)))
(
cron/with-misfire-handling-instruction-ignore-misfires
))))]
;; Schedule the repeats
(
task/schedule-task!
job
trigger
)
;; Don't wait, try to kick it off immediately
(
task/trigger-now!
job-key
)))
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment