Fix ambiguous run-query-for-dashcard endpoints (#20139)
* Rework QP.dashboard to expect dashcard-id
* Update /api/dashboard endpoints
* Rework public endpoints for running queries for Dashcards
* Tweak parameter order for Dashboard endpoints for consistency
* Pulse should pass Dashcard ID
* Embed should pass Dashcard ID
* Unskip cypress test
* Update API documentation
* Update endpoints and pass dashcardId to endpoint fns
* Update cypress tests that reference previous endpoint
* Update placement of pivot in endpoint
* Update another endpoint + more e2e fixes
* update QB to hold onto dashcardId like it does with dashboardId
* Address PR feedback
Co-authored-by:
Dalton Johnson <daltojohnso@users.noreply.github.com>
Showing
- docs/api-documentation.md 40 additions, 21 deletionsdocs/api-documentation.md
- frontend/src/metabase-lib/lib/Question.ts 19 additions, 3 deletionsfrontend/src/metabase-lib/lib/Question.ts
- frontend/src/metabase/dashboard/actions.js 6 additions, 1 deletionfrontend/src/metabase/dashboard/actions.js
- frontend/src/metabase/lib/card.js 1 addition, 0 deletionsfrontend/src/metabase/lib/card.js
- frontend/src/metabase/parameters/utils/dashboards.js 5 additions, 1 deletionfrontend/src/metabase/parameters/utils/dashboards.js
- frontend/src/metabase/parameters/utils/dashboards.unit.spec.js 17 additions, 0 deletions...end/src/metabase/parameters/utils/dashboards.unit.spec.js
- frontend/src/metabase/query_builder/actions.js 16 additions, 3 deletionsfrontend/src/metabase/query_builder/actions.js
- frontend/src/metabase/services.js 11 additions, 5 deletionsfrontend/src/metabase/services.js
- frontend/test/metabase-lib/lib/Question.unit.spec.js 8 additions, 4 deletionsfrontend/test/metabase-lib/lib/Question.unit.spec.js
- frontend/test/metabase/scenarios/dashboard-filters/reproductions/12720-no-data-permissions-connected-filter.cy.spec.js 3 additions, 1 deletion...ons/12720-no-data-permissions-connected-filter.cy.spec.js
- frontend/test/metabase/scenarios/dashboard-filters/reproductions/13150-additional-card-queries-for-all-filters.cy.spec.js 3 additions, 1 deletion.../13150-additional-card-queries-for-all-filters.cy.spec.js
- frontend/test/metabase/scenarios/dashboard-filters/reproductions/13960-do-not-preserve-cleared-default-filter-on-refresh.cy.spec.js 1 addition, 1 deletion...not-preserve-cleared-default-filter-on-refresh.cy.spec.js
- frontend/test/metabase/scenarios/dashboard-filters/reproductions/17212-nested-id-filter.cy.spec.js 1 addition, 1 deletion...d-filters/reproductions/17212-nested-id-filter.cy.spec.js
- frontend/test/metabase/scenarios/dashboard-filters/reproductions/19494-wrong-default-value-multiple-cards-same-question.cy.spec.js 1 addition, 1 deletion...ong-default-value-multiple-cards-same-question.cy.spec.js
- frontend/test/metabase/scenarios/dashboard/click-behavior.cy.spec.js 2 additions, 2 deletions...st/metabase/scenarios/dashboard/click-behavior.cy.spec.js
- frontend/test/metabase/scenarios/dashboard/dashboard-drill.cy.spec.js 2 additions, 2 deletions...t/metabase/scenarios/dashboard/dashboard-drill.cy.spec.js
- frontend/test/metabase/scenarios/dashboard/reproductions/18454-card-description.cy.spec.js 1 addition, 1 deletion...dashboard/reproductions/18454-card-description.cy.spec.js
- frontend/test/metabase/scenarios/dashboard/title-drill.cy.spec.js 1 addition, 1 deletion.../test/metabase/scenarios/dashboard/title-drill.cy.spec.js
- frontend/test/metabase/scenarios/question/reproductions/17514-ui-overlay.cy.spec.js 1 addition, 1 deletion...narios/question/reproductions/17514-ui-overlay.cy.spec.js
- frontend/test/metabase/scenarios/visualizations/drillthroughs/dash_drill.cy.spec.js 2 additions, 2 deletions...narios/visualizations/drillthroughs/dash_drill.cy.spec.js
Loading
Please register or sign in to comment