Remove superuser checks from new endpoints

src/metabase/api/metric.clj

@@ -27,11 +27,10 @@
   (check-404 (metric/retrieve-metric id)))
 
 (defendpoint GET "/"
-  "Fetch all `Metrics`. You must be a superuser to do this."
+  "Fetch *all* `Metrics`."
   [id]
-  (check-superuser)
-  (check-404 (-> (db/select Metric, :is_active true)
-                 (hydrate :creator))))
+  (-> (db/select Metric, :is_active true)
+      (hydrate :creator)))
 
 
 (defendpoint PUT "/:id"

src/metabase/api/segment.clj

@@ -27,9 +27,8 @@
   (check-404 (segment/retrieve-segment id)))
 
 (defendpoint GET "/"
-  "Fetch *all* `Segments`. You must be a superuser."
+  "Fetch *all* `Segments`."
   []
-  (check-superuser)
   (-> (db/select Segment, :is_active true)
       (hydrate :creator)))
 

test/metabase/api/metric_test.clj

@@ -329,9 +329,4 @@
                       Metric [_        {:is_active false}]] ; inactive metrics shouldn't show up
   (tu/mappify (hydrate [metric-1
                         metric-2] :creator))
-  ((user->client :crowberto) :get 200 "metric/"))
-
-;; non-admin users shouldn't be allowed to use this endpoint -- should get a 403
-(expect
-  "You don't have permissions to do that."
-  ((user->client :rasta) :get 403 "metric/"))
+  ((user->client :rasta) :get 200 "metric/"))

test/metabase/api/segment_test.clj

@@ -334,9 +334,4 @@
                       Segment [_          {:is_active false}]] ; inactive segments shouldn't show up
   (tu/mappify (hydrate [segment-1
                         segment-2] :creator))
-  ((user->client :crowberto) :get 200 "segment/"))
-
-;; non-admin users shouldn't be allowed to use this endpoint -- should get a 403
-(expect
-  "You don't have permissions to do that."
-  ((user->client :rasta) :get 403 "segment/"))
+  ((user->client :rasta) :get 200 "segment/"))