Smoketests/skips and type issues (#12890)

* added skips to admin_setup

* added .visit()s and to fix .type() issue

* added comment

frontend/test/metabase-smoketest/admin.cy.spec.js

@@ -161,6 +161,7 @@ describe("metabase-smoketest > admin", () => {
     });
 
     it("should add a simple JOINed question as admin", () => {
+      cy.visit("/");
       cy.findByText("Ask a question");
 
       cy.findByText("Ask a question").click();
@@ -200,6 +201,7 @@ describe("metabase-smoketest > admin", () => {
     });
 
     it("should add a question with a default line visualization as admin", () => {
+      cy.visit("/");
       cy.findByText("Ask a question").click();
 
       cy.findByText("Native query");
@@ -236,6 +238,7 @@ describe("metabase-smoketest > admin", () => {
     });
 
     it("should create a new dashboard with the previous questions as admin", () => {
+      cy.visit("/");
       // New dashboard
       cy.get(".Icon-add").click();
       cy.findByText("New dashboard").click();

frontend/test/metabase-smoketest/admin_setup.cy.spec.js

@@ -60,7 +60,7 @@ describe("smoketest > admin_setup", () => {
       // cy.findByText("Save").click();
     });
 
-    it("should setup email", () => {
+    it.skip("should setup email", () => {
       cy.findByText("Settings").click();
       cy.findByText("Email").click();
 
@@ -96,7 +96,7 @@ describe("smoketest > admin_setup", () => {
       // );
     });
 
-    it("should setup Slack", () => {
+    it.skip("should setup Slack", () => {
       cy.findByText("Slack").click();
 
       cy.findByText("Answers sent right to your Slack #channels");
@@ -905,7 +905,8 @@ describe("smoketest > admin_setup", () => {
       cy.findByLabelText("Name")
         .clear()
         .wait(1)
-        .type("q for sub-collection");
+        .type("sub-collection question");
+      cy.findByText("sub-collection question");
       cy.findByText("Robert Tableton's Personal Collection").click();
 
       cy.findByText("My personal collection");
@@ -921,11 +922,10 @@ describe("smoketest > admin_setup", () => {
       cy.findByText("Sorry, you don’t have permission to see that.").should(
         "not.exist",
       );
-      cy.findByText("q for sub-collection");
+      cy.findByText("sub-collection question");
 
       // Check access as no collection user
 
-      signOut();
       signIn("nocollection");
       cy.visit("/");
 
@@ -940,11 +940,11 @@ describe("smoketest > admin_setup", () => {
     });
 
     it("should be unable to access question with URL (if access not permitted)", () => {
-      signOut();
+      // This test will fail whenever the previous test fails
       signIn("nocollection");
 
       cy.visit("/question/4");
-      cy.findByText("q for sub-collection").should("not.exist");
+      cy.findByText("sub-collection question").should("not.exist");
       cy.findByText("Sorry, you don’t have permission to see that.");
     });
 

frontend/test/metabase-smoketest/user.cy.spec.js

@@ -234,7 +234,7 @@ describe("smoketest > user", () => {
 
     cy.findByText("User → ID");
     cy.findByText("Created At");
-    cy.findByText("People");
+    cy.findByText("Orders + People");
 
     // Setting Row limit