Skip to content
Snippets Groups Projects
Unverified Commit 9f73b0ce authored by Cal Herries's avatar Cal Herries Committed by GitHub
Browse files

Skip fingerprinting or scanning field values for fields with base_type=type/* (#43483)

parent 12e25b65
Branches
Tags
No related merge requests found
......@@ -235,6 +235,7 @@
(not (isa? base-type :type/field-values-unsupported))
(not (contains? #{:retired :sensitive :hidden :details-only} (keyword visibility-type)))
(not (isa? (keyword base-type) :type/Temporal))
(not (= (keyword base-type) :type/*))
(#{:list :auto-list} (keyword has-field-values)))))))
(defn take-by-length
......
......@@ -160,6 +160,7 @@
[:not (mdb.query/isa :semantic_type :type/PK)]
[:= :semantic_type nil]]
[:not-in :visibility_type ["retired" "sensitive"]]
[:not= :base_type (u/qualified-name :type/*)]
[:not (mdb.query/isa :base_type :type/Structured)]])
(def ^:dynamic *refingerprint?*
......
......@@ -90,6 +90,12 @@
{:base_type :type/Time
:has_field_values :list
:visibility_type :normal}
false}
"type/* fields should be excluded"
{{:has_field_values :list
:visibility_type :normal
:base_type :type/*}
false}}
[input expected] input->expected]
(testing (str group "\n")
......
......@@ -36,6 +36,7 @@
[:not (mdb.query/isa :semantic_type :type/PK)]
[:= :semantic_type nil]]
[:not-in :visibility_type ["retired" "sensitive"]]
[:not= :base_type "type/*"]
[:not (mdb.query/isa :base_type :type/Structured)]
[:or
[:and
......@@ -52,6 +53,7 @@
[:not (mdb.query/isa :semantic_type :type/PK)]
[:= :semantic_type nil]]
[:not-in :visibility_type ["retired" "sensitive"]]
[:not= :base_type "type/*"]
[:not (mdb.query/isa :base_type :type/Structured)]
[:or
[:and
......@@ -74,6 +76,7 @@
[:not (mdb.query/isa :semantic_type :type/PK)]
[:= :semantic_type nil]]
[:not-in :visibility_type ["retired" "sensitive"]]
[:not= :base_type "type/*"]
[:not (mdb.query/isa :base_type :type/Structured)]
[:or
[:and
......@@ -97,6 +100,7 @@
[:not (mdb.query/isa :semantic_type :type/PK)]
[:= :semantic_type nil]]
[:not-in :visibility_type ["retired" "sensitive"]]
[:not= :base_type "type/*"]
[:not (mdb.query/isa :base_type :type/Structured)]
[:or
[:and
......@@ -125,6 +129,7 @@
[:not (mdb.query/isa :semantic_type :type/PK)]
[:= :semantic_type nil]]
[:not-in :visibility_type ["retired" "sensitive"]]
[:not= :base_type "type/*"]
[:not (mdb.query/isa :base_type :type/Structured)]]}
(binding [sync.fingerprint/*refingerprint?* true]
(#'sync.fingerprint/honeysql-for-fields-that-need-fingerprint-updating))))))
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment