Automatically select offset breakout or move it to the front (#46573)
* Add defaultTemporalBucket helper * Add helper to pick default breakout * Move breakout to the front or add one if it does not exist * Add updateQuery to AggregationPicker props * Add tests for creation and reordering of temporal breakouts * Reuse defaultTemporalBucket in withDefaultTemporalBucket * Reorder query operations to make sure the correct names get generated * Remove dependency on referential equality of breakout * Rename updateQuery to onQueryChange * Remove onAddAggregations and onUpdateAggregation for onQueryChange * Extract query update in to separate function * Remove on{Add,Update,Remove}Aggregation in favor of onQueryChange * Remove aggregations from summarize details * Fix e2e tests * Remove conflicting test * Fix recent clause in unit tests * Fix superflouous check for columnAndBucket * Future proof breakout check * Remove reliance on details in the useSummarize hook * Remove details in unit tests * Removal of default summarization should not trigger a query change
Showing
- e2e/test/scenarios/question/column-compare.cy.spec.ts 275 additions, 33 deletionse2e/test/scenarios/question/column-compare.cy.spec.ts
- enterprise/frontend/src/embedding-sdk/components/public/InteractiveQuestion/components/Summarize.tsx 2 additions, 6 deletions...nents/public/InteractiveQuestion/components/Summarize.tsx
- frontend/src/metabase-lib/temporal_bucket.ts 11 additions, 1 deletionfrontend/src/metabase-lib/temporal_bucket.ts
- frontend/src/metabase/common/components/AggregationPicker/AggregationPicker.tsx 24 additions, 7 deletions...common/components/AggregationPicker/AggregationPicker.tsx
- frontend/src/metabase/common/components/AggregationPicker/AggregationPicker.unit.spec.tsx 19 additions, 25 deletions...ponents/AggregationPicker/AggregationPicker.unit.spec.tsx
- frontend/src/metabase/query_builder/components/CompareAggregations/CompareAggregations.tsx 30 additions, 12 deletions...er/components/CompareAggregations/CompareAggregations.tsx
- frontend/src/metabase/query_builder/components/CompareAggregations/CompareAggregations.unit.spec.tsx 2 additions, 2 deletions...nts/CompareAggregations/CompareAggregations.unit.spec.tsx
- frontend/src/metabase/query_builder/components/CompareAggregations/utils.ts 111 additions, 0 deletions...ase/query_builder/components/CompareAggregations/utils.ts
- frontend/src/metabase/query_builder/components/notebook/steps/AggregateStep/AggregateStep.tsx 4 additions, 40 deletions...components/notebook/steps/AggregateStep/AggregateStep.tsx
- frontend/src/metabase/query_builder/components/view/sidebars/SummarizeSidebar/AddAggregationButton/AddAggregationButton.tsx 4 additions, 8 deletions...rizeSidebar/AddAggregationButton/AddAggregationButton.tsx
- frontend/src/metabase/query_builder/components/view/sidebars/SummarizeSidebar/AggregationItem/AggregationItem.tsx 10 additions, 13 deletions...bars/SummarizeSidebar/AggregationItem/AggregationItem.tsx
- frontend/src/metabase/query_builder/components/view/sidebars/SummarizeSidebar/SummarizeContent/SummarizeAggregationItemList.tsx 4 additions, 15 deletions...Sidebar/SummarizeContent/SummarizeAggregationItemList.tsx
- frontend/src/metabase/query_builder/components/view/sidebars/SummarizeSidebar/SummarizeContent/use-summarize-query.ts 7 additions, 32 deletions.../SummarizeSidebar/SummarizeContent/use-summarize-query.ts
- frontend/src/metabase/query_builder/components/view/sidebars/SummarizeSidebar/SummarizeSidebar.tsx 2 additions, 6 deletions...nents/view/sidebars/SummarizeSidebar/SummarizeSidebar.tsx
- frontend/src/metabase/querying/utils/drills/compare-aggregations-drill/compare-aggregations-drill.tsx 1 addition, 7 deletions...compare-aggregations-drill/compare-aggregations-drill.tsx
- frontend/src/metabase/visualizations/click-actions/actions/CompareAggregationsAction/CompareAggregationsAction.tsx 4 additions, 7 deletions...s/CompareAggregationsAction/CompareAggregationsAction.tsx
Loading
Please register or sign in to comment