-
- Downloads
Use Dimensions to access Fields in Parameters code (#18431)
* fix virtual field access when connecting parameters to dimensions * fix tests * lint fix * maybe keep things a little more backwards compatible * fix cy test * stop messing with field array ids * look for virtual fields on nested questions + tests * fix dashboard mapping test * fix cy test * add parameterToMBQLFilter tests * remove direct FIELD_REF usage * revert a few changes * Update frontend/src/metabase-lib/lib/Dimension.js Co-authored-by:Gustavo Saiani <gustavo@poe.ma> Co-authored-by:
Gustavo Saiani <gustavo@poe.ma>
Showing
- frontend/src/metabase-lib/lib/Dimension.js 42 additions, 10 deletionsfrontend/src/metabase-lib/lib/Dimension.js
- frontend/src/metabase-lib/lib/Question.js 5 additions, 0 deletionsfrontend/src/metabase-lib/lib/Question.js
- frontend/src/metabase/dashboard/selectors.unit.spec.js 2 additions, 2 deletionsfrontend/src/metabase/dashboard/selectors.unit.spec.js
- frontend/src/metabase/meta/Card.js 9 additions, 8 deletionsfrontend/src/metabase/meta/Card.js
- frontend/src/metabase/meta/Dashboard.js 3 additions, 12 deletionsfrontend/src/metabase/meta/Dashboard.js
- frontend/src/metabase/meta/Parameter.js 34 additions, 32 deletionsfrontend/src/metabase/meta/Parameter.js
- frontend/src/metabase/public/containers/PublicQuestion.jsx 7 additions, 2 deletionsfrontend/src/metabase/public/containers/PublicQuestion.jsx
- frontend/src/metabase/query_builder/actions.js 4 additions, 1 deletionfrontend/src/metabase/query_builder/actions.js
- frontend/src/metabase/query_builder/selectors.js 7 additions, 3 deletionsfrontend/src/metabase/query_builder/selectors.js
- frontend/test/metabase-lib/lib/Dimension.unit.spec.js 257 additions, 32 deletionsfrontend/test/metabase-lib/lib/Dimension.unit.spec.js
- frontend/test/metabase-lib/lib/Question.unit.spec.js 18 additions, 0 deletionsfrontend/test/metabase-lib/lib/Question.unit.spec.js
- frontend/test/metabase/meta/Dashboard.unit.spec.js 19 additions, 48 deletionsfrontend/test/metabase/meta/Dashboard.unit.spec.js
- frontend/test/metabase/meta/Parameter.unit.spec.js 119 additions, 0 deletionsfrontend/test/metabase/meta/Parameter.unit.spec.js
- frontend/test/metabase/scenarios/admin/audit/auditing.cy.spec.js 1 addition, 1 deletion...d/test/metabase/scenarios/admin/audit/auditing.cy.spec.js
- frontend/test/metabase/scenarios/question/view.cy.spec.js 15 additions, 8 deletionsfrontend/test/metabase/scenarios/question/view.cy.spec.js
Loading
Please register or sign in to comment