Skip to content

GitLab

Explore

Sign in

Primary navigation

Project

M

Metabase
- Activity
- Members
- Labels
- Issues
- Issue boards
- Milestones
- Iterations
- Wiki
- Requirements
- Environments
- Terraform modules
- Incidents
- Service Desk

Snippets Groups Projects

a5cd7d04

Unverified Commit a5cd7d04 authored 8 months ago by Emmad Usmani Committed by GitHub 8 months ago

Downloads
- Patches
- Plain Diff

fix viz settings not persisted during question edit (#46308)

* fix lost settings

* add e2e test

* trigger ci

parent cd6cadf0

Branches

Tags

No related merge requests found

Changes 4

Hide whitespace changes

Inline Side-by-side

Showing

e2e/test/scenarios/native/native-reproductions.cy.spec.js 51 additions, 1 deletion

e2e/test/scenarios/native/native-reproductions.cy.spec.js
frontend/src/metabase/static-viz/components/ComboChart/settings.ts 1 addition, 1 deletion

...src/metabase/static-viz/components/ComboChart/settings.ts
frontend/src/metabase/visualizations/lib/settings/graph.js 1 addition, 1 deletion

frontend/src/metabase/visualizations/lib/settings/graph.js
frontend/src/metabase/visualizations/shared/settings/cartesian-chart.ts 26 additions, 6 deletions

...etabase/visualizations/shared/settings/cartesian-chart.ts

with 79 additions and 9 deletions

Loading

0% Loading or .

You are about to add 0 people to the discussion. Proceed with caution.

Finish editing this message first!

Please register or sign in to comment