Skip to content
Snippets Groups Projects
Unverified Commit a603d3d4 authored by Tom Robinson's avatar Tom Robinson Committed by GitHub
Browse files

Merge pull request #8099 from metabase/increase-generated-password-complexity

Restore previous minimum generated password length of 14
parents c33b78b0 0189831c
No related branches found
No related tags found
No related merge requests found
......@@ -48,8 +48,9 @@ let MetabaseUtils = {
generatePassword: function(complexity) {
complexity =
complexity || MetabaseSettings.passwordComplexityRequirements() || {};
// fall back to length of 14 if the password_complexity Setting isn't set or total isn't passed in
const len = complexity.total || 14;
// generated password must be at least `complexity.total`, but can be longer
// so hard code a minimum of 14
const len = Math.max(complexity.total || 0, 14);
let password = "";
let tries = 0;
......
......@@ -3,9 +3,14 @@ import MetabaseSettings from "metabase/lib/settings";
describe("utils", () => {
describe("generatePassword", () => {
it("defaults to complexity requirements from Settings", () => {
it("defaults to at least 14 characters even if password_complexity requirements are lower", () => {
MetabaseSettings.set("password_complexity", { total: 10 });
expect(MetabaseUtils.generatePassword().length).toBe(10);
expect(MetabaseUtils.generatePassword().length).toBe(14);
});
it("defaults to complexity requirements if greater than 14", () => {
MetabaseSettings.set("password_complexity", { total: 20 });
expect(MetabaseUtils.generatePassword().length).toBe(20);
});
it("falls back to length 14 passwords", () => {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment