Skip to content
Snippets Groups Projects
Commit a63895a3 authored by Cam Saül's avatar Cam Saül
Browse files

Add some notes :notes: [ci skip]

parent 501c9ad3
Branches
Tags
No related merge requests found
......@@ -30,6 +30,7 @@
;; TODO - Endpoint for editing the settings above? Or just edit them the normal way via PUT /api/setting/:key ?
;; TODO - Endpoint for setting most_important_dashboard (?) Or just have people set it the normal way via PUT /api/dashboard/:id ?
;; If we keep the existing endpoint it might make sense to clear `show_in_getting_started` for other Dashboards whenever this is set
;; TODO - Endpoints for setting most important metrics / tables / segments ? Or just have people set them the normal way via PUT /api/.../:id ?
(define-routes)
......@@ -65,9 +65,8 @@
(when (seq fields-to-remove)
(db/delete! 'MetricImportantField {:metric_id id, :field_id [:in fields-to-remove]}))
;; add new fields as needed
(when (seq fields-to-add)
(db/insert-many! 'MetricImportantField (for [field-id fields-to-add]
{:metric_id id, :field_id field-id})))
(db/insert-many! 'MetricImportantField (for [field-id fields-to-add]
{:metric_id id, :field_id field-id}))
;; we're done (TODO - Do we want to return anything here?)
{:success true}))
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment