Navbar Improvements: Embedding (#38053)

e2e/test/scenarios/embedding/embedding-full-app.cy.spec.js

@@ -100,6 +100,18 @@ describeEE("scenarios > embedding > full app", () => {
       sideNav().should("not.exist");
     });
 
+    it("should disable home link when top nav is enabeld but side nav is disabled", () => {
+      visitDashboardUrl({
+        url: `/dashboard/${ORDERS_DASHBOARD_ID}`,
+        qs: { top_nav: true, side_nav: false },
+      });
+      cy.findByTestId("main-logo-link").should(
+        "have.attr",
+        "disabled",
+        "disabled",
+      );
+    });
+
     it("should show question creation controls by a param", () => {
       visitFullAppEmbeddingUrl({ url: "/", qs: { new_button: true } });
       appBar().within(() => {

frontend/src/metabase/nav/components/AppBar/AppBarLarge.tsx

@@ -51,7 +51,10 @@ const AppBarLarge = ({
           isNavBarOpen={isNavBarOpen}
           onToggleClick={onToggleNavbar}
         />
-        <AppBarLogo isLogoVisible={isLogoVisible} />
+        <AppBarLogo
+          isLogoVisible={isLogoVisible}
+          isNavBarEnabled={isNavBarEnabled}
+        />
         <AppBarInfoContainer
           isVisible={!isNavBarVisible || isQuestionLineageVisible}
         >

frontend/src/metabase/nav/components/AppBar/AppBarLogo.styled.tsx

@@ -10,6 +10,7 @@ export const LogoLink = styled(Link)<{ isSmallAppBar: boolean }>`
   border-radius: 0.375rem;
   width: 2.25rem;
   height: 3.25rem;
+  opacity: 1;
   ${props =>
     !props.isSmallAppBar &&
     css`

frontend/src/metabase/nav/components/AppBar/AppBarLogo.tsx

@@ -4,12 +4,14 @@ import { LogoLink } from "./AppBarLogo.styled";
 export interface AppBarLogoProps {
   isSmallAppBar?: boolean;
   isLogoVisible?: boolean;
+  isNavBarEnabled?: boolean;
   onLogoClick?: () => void;
 }
 
 export function AppBarLogo({
   isLogoVisible,
   isSmallAppBar,
+  isNavBarEnabled,
   onLogoClick,
 }: AppBarLogoProps): JSX.Element | null {
   if (!isLogoVisible) {
@@ -21,6 +23,7 @@ export function AppBarLogo({
       to="/"
       isSmallAppBar={Boolean(isSmallAppBar)}
       onClick={onLogoClick}
+      disabled={!isNavBarEnabled}
       data-metabase-event="Navbar;Logo"
       data-testid="main-logo-link"
     >

frontend/src/metabase/nav/components/AppBar/AppBarSmall.tsx

@@ -89,6 +89,7 @@ const AppBarSmall = ({
             <AppBarLogo
               isSmallAppBar
               isLogoVisible={isLogoVisible}
+              isNavBarEnabled={isNavBarEnabled}
               onLogoClick={onCloseNavbar}
             />
           </AppBarLogoContainer>